Repository navigation
feat: add API v2 configuration CRDs - #2426
Merged
Merged
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
force-pushed
the
api-v2-k1-crds
branch
from
August 11, 2026 23:06
edb7db3 to
0f462d8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the final API v2 configuration contracts to the codebase by introducing the kagent.dev/v1alpha3 Harness and AgentTemplate CRDs (plus generated artifacts), wiring them into Helm installation, and capturing the API v2 execution plan + updated skill guidance.
Changes:
- Introduce new v1alpha3 configuration CRDs (
Harness,AgentTemplate) with CEL validations and Go types, plus generated deepcopy + CRD manifests. - Update Helm charts (CRD chart + controller RBAC) to install and operate on the new resources.
- Add envtest-based validation coverage for key CEL invariants, and document the API v2 execution plan / update embedded skills docs to match the new API direction.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| helm/kagent/templates/rbac/writer-role.yaml | Grants controller write permissions over new harnesses and agenttemplates resources. |
| helm/kagent/templates/rbac/getter-role.yaml | Extends controller read/status/finalizer permissions to new CRDs. |
| helm/kagent-crds/templates/kagent.dev_harnesses.yaml | Helm-installed CRD manifest for Harness (v1alpha3). |
| helm/kagent-crds/templates/kagent.dev_agenttemplates.yaml | Helm-installed CRD manifest for AgentTemplate (v1alpha3). |
| go/api/v1alpha3/harness_types.go | Defines the v1alpha3 Harness API type and validation markers. |
| go/api/v1alpha3/agenttemplate_types.go | Defines the v1alpha3 AgentTemplate API type and validation markers. |
| go/api/v1alpha3/configuration_crd_cel_test.go | Adds envtest coverage to pin key CEL validations for new configuration CRDs. |
| go/api/v1alpha3/zz_generated.deepcopy.go | Regenerated deepcopy implementations for new types. |
| go/api/config/crd/bases/kagent.dev_harnesses.yaml | Generated CRD bases output for Harness. |
| go/api/config/crd/bases/kagent.dev_agenttemplates.yaml | Generated CRD bases output for AgentTemplate. |
| docs/plans/api-v2-execution-plan.md | Records the API v2 execution plan and milestone breakdown (K1 marked complete). |
| .claude/skills/kagent/SKILL.md | Updates the user-facing kagent skill guidance to align with the new API surface and roadmap. |
| .claude/skills/kagent/references/troubleshooting.md | Removes legacy v1alpha2-era user guidance content that no longer applies to the new API direction. |
| .claude/skills/kagent/references/providers.md | Removes legacy provider configuration guidance tied to the older workflow. |
| .claude/skills/kagent/references/mcp-ide-setup.md | Removes legacy MCP IDE setup guidance tied to older controller endpoints/workflows. |
| .claude/skills/kagent/references/cli-reference.md | Removes legacy CLI workflow guidance that is expected to change under API v2. |
| .claude/skills/kagent/references/agent-configuration.md | Removes legacy agent configuration reference (v1alpha2 SandboxAgent-centric). |
| .claude/skills/kagent/evals/evals.json | Removes eval prompts/expected outputs tied to legacy CLI + v1alpha2 concepts. |
| .claude/skills/kagent-dev/SKILL.md | Updates developer skill to reflect the new v1alpha3 + AgentInstance/A2A/Substrate roadmap and conventions. |
| .claude/skills/kagent-dev/references/translator-guide.md | Removes legacy translator guidance that doesn’t apply to the new API v2 preparation/compiler track. |
| .claude/skills/kagent-dev/references/e2e-debugging.md | Removes legacy E2E debugging guide content tied to older workflows/tests. |
| .claude/skills/kagent-dev/references/database-migrations.md | Removes legacy DB migration guidance content (superseded by updated roadmap/structure). |
| .claude/skills/kagent-dev/references/crd-workflow-detailed.md | Removes legacy CRD workflow examples focused on older CRDs. |
| .claude/skills/kagent-dev/references/ci-failures.md | Removes legacy CI failure guide content tied to previous generation/test workflows. |
| .claude/skills/kagent-dev/evals/evals.json | Removes eval prompts/expected outputs tied to legacy CRDs and workflows. |
Files not reviewed (1)
- go/api/v1alpha3/zz_generated.deepcopy.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
make controller-manifests(repeated; generated hashes stable)go test ./api/v1alpha3go vet ./api/v1alpha3golangci-lint run ./api/v1alpha3/...helm lint helm/kagent-crdshelm lint helm/kagentgit diff --checkScope
This PR only adds configuration contracts. It does not add reconciliation, preparation, AgentInstance lifecycle, or runtime A2A behavior.