Skip to content

feat: support responses api in kagent harness - #2369

Merged
EItanya merged 6 commits into
kagent-dev:mainfrom
supreme-gg-gg:feat/responses-api
Jul 31, 2026
Merged

feat: support responses api in kagent harness#2369
EItanya merged 6 commits into
kagent-dev:mainfrom
supreme-gg-gg:feat/responses-api

Conversation

@supreme-gg-gg

@supreme-gg-gg supreme-gg-gg commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Users can now use the Responses API either directly with OpenAI or via a gateway like AgentGateway. Here's an example with agent gateway.

apiVersion: kagent.dev/v1alpha2
kind: ModelConfig
metadata:
  name: openai-responses
  namespace: kagent
spec:
  provider: OpenAI
  model: gpt-5.4-mini
  apiKeyPassthrough: true
  openAI:
    baseUrl: http://agentgateway-proxy.agentgateway-system.svc/openai
    apiFormat: responses # NEW! <- If not provided, uses chat completions API

Note that certain features from Responses API like native tools and stateful chaining are not supported for now since they're only available when using with OpenAI's servers. For those interested, it can be a follow up to add those features in kagent harness.

@supreme-gg-gg
responses api
99f4d79 
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 30, 2026
@supreme-gg-gg
fix go lint
47483ad 
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
@supreme-gg-gg
manifests
e876b78 
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
@supreme-gg-gg
Merge branch 'main' into feat/responses-api
a533cfc
@supreme-gg-gg
supreme-gg-gg marked this pull request as ready for review July 31, 2026 15:55
@supreme-gg-gg
supreme-gg-gg requested a review from a team as a code owner July 31, 2026 15:55
Copilot AI review requested due to automatic review settings July 31, 2026 15:55
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

EItanya
EItanya reviewed Jul 31, 2026
View reviewed changes
Comment thread go/adk/pkg/models/openai.go

// OpenAI API format values (ModelConfig openAI.apiFormat).
const (
OpenAIAPIFormatChatCompletions = "chatCompletions"

@EItanya EItanya Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just call this completions?

@supreme-gg-gg supreme-gg-gg Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately OpenAI has a deprecated API called "completions" which is the legacy version of "chat completions", so it might be a bit confusing

@EItanya EItanya Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool, I didn’t know that

Comment thread go/api/v1alpha2/modelconfig_types.go
type OpenAIAPIFormat string

const (
OpenAIAPIFormatChatCompletions OpenAIAPIFormat = "chatCompletions"

@EItanya EItanya Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

Comment thread go/adk/pkg/models/openai_adk.go
@@ -128,7 +128,6 @@ func (m *OpenAIModel) Name() string {
// GenerateContent implements model.LLM. Uses only ADK/genai types.
func (m *OpenAIModel) GenerateContent(ctx context.Context, req *model.LLMRequest, stream bool) iter.Seq2[*model.LLMResponse, error] {

@EItanya EItanya Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be separate structs since they don't really share much?

@supreme-gg-gg supreme-gg-gg Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the OpenAIModel struct contains shared config, client, logging setup (in openai.go), and this structure represents a "model provider" so imo there should only be one of it, and it would handle the response formats internally. I've made a change to make the api format handling cleaner in b36dd6f

@EItanya
EItanya enabled auto-merge (squash) July 31, 2026 19:21
@EItanya
EItanya merged commit fad2d0c into kagent-dev:main Jul 31, 2026
44 of 56 checks passed
@supreme-gg-gg supreme-gg-gg mentioned this pull request Jul 31, 2026
Merged
EItanya pushed a commit that referenced this pull request Jul 31, 2026
@supreme-gg-gg
Backport 2369 to 0.10.x release branch (#2375)
54a3cd9 
#2369

Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
@jeremiedeveloper jeremiedeveloper mentioned this pull request Aug 21, 2026
Closed
3 tasks done
onematchfox added a commit to onematchfox/kagent that referenced this pull request Sep 3, 2026
@onematchfox
feat(adk): support responses API for Python agents
927ad98 
Responses API is required in order to use reasoning effort with newer Open AI models.  kagent-dev#2369 (backported to `v0.10.x` in kagent-dev#2375) introduced support for use of the Responses API (configured via ModelConfig). However, that PR was strictly limited to golang agents and at present Python agents completely ignore the configuration and as such requests to a new model configured with reasoning effort will fail. This PR completes kagent-dev#2369 by ensuring that Python ADK agents also make use of the Responses API as per model configuration.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
@onematchfox onematchfox mentioned this pull request Sep 3, 2026
Merged
onematchfox added a commit to onematchfox/kagent that referenced this pull request Sep 3, 2026
@onematchfox
feat(adk): support responses API for Python agents
0bd7a1a 
Responses API is required in order to use reasoning effort with newer Open AI models.  kagent-dev#2369 (backported to `v0.10.x` in kagent-dev#2375) introduced support for use of the Responses API (configured via ModelConfig). However, that PR was strictly limited to golang agents and at present Python agents completely ignore the configuration and as such requests to a new model configured with reasoning effort will fail. This PR completes kagent-dev#2369 by ensuring that Python ADK agents also make use of the Responses API as per model configuration.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox added a commit to onematchfox/kagent that referenced this pull request Sep 4, 2026
@onematchfox
feat(adk): support responses API for Python agents
7a70b71 
Responses API is required in order to use reasoning effort with newer Open AI models.  kagent-dev#2369 (backported to `v0.10.x` in kagent-dev#2375) introduced support for use of the Responses API (configured via ModelConfig). However, that PR was strictly limited to golang agents and at present Python agents completely ignore the configuration and as such requests to a new model configured with reasoning effort will fail. This PR completes kagent-dev#2369 by ensuring that Python ADK agents also make use of the Responses API as per model configuration.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox added a commit to onematchfox/kagent that referenced this pull request Sep 4, 2026
@onematchfox
feat(adk): support responses API for Python agents
a83b0b5 
Responses API is required in order to use reasoning effort with newer Open AI models.  kagent-dev#2369 (backported to `v0.10.x` in kagent-dev#2375) introduced support for use of the Responses API (configured via ModelConfig). However, that PR was strictly limited to golang agents and at present Python agents completely ignore the configuration and as such requests to a new model configured with reasoning effort will fail. This PR completes kagent-dev#2369 by ensuring that Python ADK agents also make use of the Responses API as per model configuration.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
EItanya added a commit that referenced this pull request Sep 4, 2026
@onematchfox @EItanya
feat(adk): support responses API for Python ADK agents (#2679)
cae75fa 
Responses API is required in order to use reasoning effort with newer
Open AI models. #2369 (backported to `v0.10.x` in #2375) introduced
support for use of the Responses API (configured via ModelConfig).
However, that PR was strictly limited to golang agents and at present
Python agents completely ignore the configuration and as such requests
to a new model configured with reasoning effort will fail. This PR
completes #2369 by ensuring that Python ADK agents also make use of the
Responses API as per model configuration.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
@BrewTestBot BrewTestBot mentioned this pull request Nov 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@EItanya EItanya EItanya approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@supreme-gg-gg @EItanya
⌂ 换网址