Repository navigation
fix: pass includeConfig.force to newNestedOperator - #1463
Merged
Merged
Conversation
includeConfig.force was parsed from include step config but never
passed to newNestedOperator, so `include: { force: true }` did not
actually force-continue on step failures inside the included runbook.
Fixes #1436
This comment has been minimized.
This comment has been minimized.
Contributor
BenchmarkManyRunbooks-4
Metadata
BenchmarkOpenAPI3-4
Metadata
BenchmarkSingleRunbook-4
Metadata
Reported by octocov |
Contributor
Code Metrics Report
Details | | main (20f49b2) | #1463 (25b6bc7) | +/- |
|---------------------|----------------|-----------------|-------|
+ | Coverage | 59.8% | 59.9% | +0.0% |
| Files | 85 | 85 | 0 |
| Lines | 9836 | 9836 | 0 |
+ | Covered | 5889 | 5893 | +4 |
+ | Code to Test Ratio | 1:0.8 | 1:0.8 | +0.0 |
| Code | 18460 | 18460 | 0 |
+ | Test | 15401 | 15445 | +44 |
- | Test Execution Time | 8m17s | 8m30s | +13s |Code coverage of files in pull request scope (77.8% → 78.1%)
Reported by octocov |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeConfig.forcewas parsed frominclude:step config but never passed tonewNestedOperator, soinclude: { force: true }did not actually force-continue on step failures inside the included runbookForce(c.force)to both path-based and inline include code paths ininclude.goforce: trueFixes #1436