Skip to content

fix: pass includeConfig.force to newNestedOperator - #1463

Merged
k1LoW merged 3 commits into
mainfrom
fix/include-force-option
Apr 23, 2026
Merged

k1LoW merged 3 commits into
mainfrom
fix/include-force-option

Conversation

@k1LoW

@k1LoW k1LoW commented Apr 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • includeConfig.force was parsed from include: step config but never passed to newNestedOperator, so include: { force: true } did not actually force-continue on step failures inside the included runbook
  • Added Force(c.force) to both path-based and inline include code paths in include.go
  • Added tests for both path-based and inline include with force: true

Fixes #1436

includeConfig.force was parsed from include step config but never
passed to newNestedOperator, so `include: { force: true }` did not
actually force-continue on step failures inside the included runbook.

Fixes #1436
@k1LoW k1LoW self-assigned this Apr 23, 2026
@k1LoW k1LoW added the bug Something isn't working label Apr 23, 2026
@k1LoW
k1LoW requested a review from Copilot April 23, 2026 13:15
@github-actions

This comment has been minimized.

This comment was marked as outdated.

@k1LoW
k1LoW requested a review from Copilot April 23, 2026 14:44
@github-actions

Copy link
Copy Markdown
Contributor

BenchmarkManyRunbooks-4

main (-) #1463 (25b6bc7) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,024,153,158 ns/op 4,274,762,738 ns/op 250,609,580 ns/op
Bytes allocated per iteration 1,391,619,048 B/op 1,391,484,968 B/op -134,080 B/op
Allocs per iteration 19,360,896 allocs/op 19,360,310 allocs/op -586 allocs/op
Metadata
main (-) #1463 (25b6bc7)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1463 (25b6bc7) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 1,461,604,017 ns/op 1,496,448,654 ns/op 34,844,637 ns/op
Bytes allocated per iteration 804,814,448 B/op 804,496,088 B/op -318,360 B/op
Allocs per iteration 10,848,428 allocs/op 10,848,738 allocs/op 310 allocs/op
Metadata
main (-) #1463 (25b6bc7)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1463 (25b6bc7) +/-
Number of iterations 21 21 0
Nanoseconds per iteration 51,257,280 ns/op 53,057,109 ns/op 1,799,829 ns/op
Bytes allocated per iteration 23,073,095 B/op 23,078,734 B/op 5,639 B/op
Allocs per iteration 186,966 allocs/op 186,968 allocs/op 2 allocs/op
Metadata
main (-) #1463 (25b6bc7)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

main (20f49b2) #1463 (25b6bc7) +/-
Coverage 59.8% 59.9% +0.0%
Code to Test Ratio 1:0.8 1:0.8 +0.0
Test Execution Time 8m17s 8m30s +13s
Details
  |                     | main (20f49b2) | #1463 (25b6bc7) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          59.8% |           59.9% | +0.0% |
  |   Files             |             85 |              85 |     0 |
  |   Lines             |           9836 |            9836 |     0 |
+ |   Covered           |           5889 |            5893 |    +4 |
+ | Code to Test Ratio  |          1:0.8 |           1:0.8 |  +0.0 |
  |   Code              |          18460 |           18460 |     0 |
+ |   Test              |          15401 |           15445 |   +44 |
- | Test Execution Time |          8m17s |           8m30s |  +13s |

Code coverage of files in pull request scope (77.8% → 78.1%)

Files Coverage +/- Status
force_test.go 93.1% 0.0% modified
include.go 90.2% 0.0% modified
internal/expr/expr.go 65.9% +0.7% affected
operator.go 79.0% +0.0% affected
parse.go 74.1% +0.5% affected

Reported by octocov

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@k1LoW
k1LoW merged commit db30841 into main Apr 23, 2026
13 checks passed
@k1LoW
k1LoW deleted the fix/include-force-option branch April 23, 2026 15:08
This was referenced Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

includeConfig.force is not applied to nested operator

2 participants

⌂ 换网址