Skip to content

Separate release builds from publishing and add attestations - #562

Merged
Songmu merged 6 commits into
mainfrom
attest-release-artifacts
Oct 13, 2026
Merged

Songmu merged 6 commits into
mainfrom
attest-release-artifacts

Conversation

@Songmu

@Songmu Songmu commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Separate release builds from publishing, and add build provenance attestations to release artifacts before publishing.

Summary

  • Move GoReleaser builds into reusable release-build.yml and publish from a separate job in release.yml, dispatched by tagpr on the release tag.
  • Attest archives, Linux packages, and checksums.txt before publishing. Select files from dist/artifacts.json with jq and include the provenance bundle as a release asset.
  • Disable GoReleaser release publishing and changelog generation in configuration, preserving tagpr's release notes.
  • Keep nFPM's existing epoch value as the string "1".
  • Add concise README instructions for verifying artifacts using attestations stored on GitHub.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
@github-actions

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
@github-actions

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
@github-actions

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
@github-actions

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
@github-actions

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
@Songmu Songmu changed the title Attest release artifacts before publishing Separate release builds from publishing and add attestations Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

main (fbf1c72) #562 (b60835c) +/-
Coverage 50.8% 50.8% 0.0%
Code to Test Ratio 1:1.0 1:1.0 0.0
Test Execution Time 9s 9s 0s
Details
  |                     | main (fbf1c72) | #562 (b60835c) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          50.8% |          50.8% | 0.0% |
  |   Files             |             33 |             33 |    0 |
  |   Lines             |           3561 |           3561 |    0 |
  |   Covered           |           1810 |           1810 |    0 |
  | Code to Test Ratio  |          1:1.0 |          1:1.0 |  0.0 |
  |   Code              |           7264 |           7264 |    0 |
  |   Test              |           7932 |           7932 |    0 |
  | Test Execution Time |             9s |             9s |   0s |

Reported by octocov

@Songmu
Songmu marked this pull request as ready for review October 13, 2026 08:27
@Songmu
Songmu requested a balanced review from Copilot October 13, 2026 08:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflows consistently separate build and publication while preserving release notes and correctly attesting the selected artifacts.

0 open findings

What changed in this PR

Separates release building from publishing and adds provenance attestations for release artifacts.

Changes:

  • Adds reusable build and publishing workflows.
  • Attests archives, packages, and checksums before publishing.
  • Documents artifact verification and disables GoReleaser publishing/changelog generation.
File Description
README.md Documents attestation verification.
.goreleaser.yml Disables publishing and changelog generation.
.github/​workflows/​tagpr.yml Dispatches the release workflow.
.github/​workflows/​release.yml Coordinates build and publication.
.github/​workflows/​release-build.yml Builds, attests, and uploads artifacts.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Songmu

Songmu commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

This PR separates artifact builds from release publishing and adds build provenance attestations to improve supply-chain security. Please review the changes and approve the PR if everything looks good.

For additional context, please see the following articles (in Japanese).

@k1LoW

@Songmu
Songmu requested a review from k1LoW October 13, 2026 08:36

@k1LoW k1LoW left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Songmu Looks Great To Me!!!! Thank you!!

@Songmu

Songmu commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

I'll try releasing it with this first. If it doesn't go well, I might make additional changes.

@Songmu
Songmu merged commit 68d267f into main Oct 13, 2026
2 checks passed
@Songmu
Songmu deleted the attest-release-artifacts branch October 13, 2026 12:30
@github-actions github-actions Bot mentioned this pull request Oct 13, 2026
@Songmu

Songmu commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

We were able to release it without any problems. What a relief.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址