Repository navigation
Separate release builds from publishing and add attestations - #562
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52b04f01-8965-427e-962d-406351235b13
Code Metrics Report
Details | | main (fbf1c72) | #562 (b60835c) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 50.8% | 50.8% | 0.0% |
| Files | 33 | 33 | 0 |
| Lines | 3561 | 3561 | 0 |
| Covered | 1810 | 1810 | 0 |
| Code to Test Ratio | 1:1.0 | 1:1.0 | 0.0 |
| Code | 7264 | 7264 | 0 |
| Test | 7932 | 7932 | 0 |
| Test Execution Time | 9s | 9s | 0s |Reported by octocov |
There was a problem hiding this comment.
🟢 Approval recommended
The workflows consistently separate build and publication while preserving release notes and correctly attesting the selected artifacts.
0 open findings
What changed in this PR
Separates release building from publishing and adds provenance attestations for release artifacts.
Changes:
- Adds reusable build and publishing workflows.
- Attests archives, packages, and checksums before publishing.
- Documents artifact verification and disables GoReleaser publishing/changelog generation.
| File | Description |
|---|---|
README.md |
Documents attestation verification. |
.goreleaser.yml |
Disables publishing and changelog generation. |
.github/workflows/tagpr.yml |
Dispatches the release workflow. |
.github/workflows/release.yml |
Coordinates build and publication. |
.github/workflows/release-build.yml |
Builds, attests, and uploads artifacts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This PR separates artifact builds from release publishing and adds build provenance attestations to improve supply-chain security. Please review the changes and approve the PR if everything looks good. For additional context, please see the following articles (in Japanese). |
|
I'll try releasing it with this first. If it doesn't go well, I might make additional changes. |
|
We were able to release it without any problems. What a relief. |
Separate release builds from publishing, and add build provenance attestations to release artifacts before publishing.
Summary
release-build.ymland publish from a separate job inrelease.yml, dispatched by tagpr on the release tag.checksums.txtbefore publishing. Select files fromdist/artifacts.jsonwith jq and include the provenance bundle as a release asset."1".