Repository navigation
fix: omit nonpositive table border weights - #558
Merged
Merged
Conversation
Skip zero and negative border weights when copying template styles to Google Slides update requests. Omit empty updates instead of using a wildcard field mask, while preserving positive weights and other border properties. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aea8d672-9770-415f-bca2-2d8205f31152
This comment has been minimized.
This comment has been minimized.
Restore the existing wildcard field-mask fallback and remove the documentation addition. Keep only nonpositive weight filtering and adjust regression tests to cover the preserved reset behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aea8d672-9770-415f-bca2-2d8205f31152
This comment has been minimized.
This comment has been minimized.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The integration run https://github.com/k1LoW/deck/actions/runs/38173419947 fails in
TestApplyMarkdown/testdata/tables.mdbecause Google Slides rejects a border weight of0.0.Validation
make lint