Skip to content

fix: omit nonpositive table border weights - #558

Merged
Songmu merged 2 commits into
mainfrom
fix/skip-nonpositive-table-border-weight
Oct 13, 2026
Merged

Songmu merged 2 commits into
mainfrom
fix/skip-nonpositive-table-border-weight

Conversation

@Songmu

@Songmu Songmu commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Omit zero and negative table border weights when copying template border properties into Google Slides update requests.
  • Add regression tests for border weight filtering, serialized request JSON, and preservation of other border properties.

Background

The integration run https://github.com/k1LoW/deck/actions/runs/38173419947 fails in TestApplyMarkdown/testdata/tables.md because Google Slides rejects a border weight of 0.0.

Validation

Skip zero and negative border weights when copying template styles to Google Slides update requests. Omit empty updates instead of using a wildcard field mask, while preserving positive weights and other border properties.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aea8d672-9770-415f-bca2-2d8205f31152
@github-actions

This comment has been minimized.

Restore the existing wildcard field-mask fallback and remove the documentation addition. Keep only nonpositive weight filtering and adjust regression tests to cover the preserved reset behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: aea8d672-9770-415f-bca2-2d8205f31152
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
64.8% 1:0.9 10m12s

Code coverage of files in pull request scope (70.8%, patch 100.0%)

Files Coverage Patch Coverage
table.go 70.8% 100.0%

Reported by octocov

@Songmu
Songmu marked this pull request as ready for review October 13, 2026 03:25
@Songmu
Songmu merged commit 378c332 into main Oct 13, 2026
2 of 3 checks passed
@Songmu
Songmu deleted the fix/skip-nonpositive-table-border-weight branch October 13, 2026 03:26
@github-actions github-actions Bot mentioned this pull request Oct 13, 2026
@Songmu Songmu added the bug Something isn't working label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working integration-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址