Repository navigation
ci: generate CREDITS with gocredits v1.0.0 from a make target - #553
Merged
Merged
Conversation
prerelease_for_tagpr installed gocredits through depsdev at @latest, which resolved to v0.4.0 in the tagpr runs. v0.4.0 reads the module list from go.sum, so it also tried to credit github.com/davecgh/go-spew, a module only the tests of dependencies need, found no license for it and failed the command. tagpr still updated the release pull request, so the job stayed green while CREDITS was never regenerated. The credits target installs gocredits pinned to v1.0.0, which collects the modules with go list over every platform, and prerelease_for_tagpr calls it. go list downloads what it reads, so the go mod download step goes, and prerelease_for_tagpr no longer needs depsdev. depsdev is left as an empty target because ci still depends on it.
Homebrew/actions no longer has a master branch, only main, so the Test job fails in Set up job with "unable to find version `master`" before running anything, on this branch and on the dependabot pull requests alike.
Contributor
Code Metrics Report
Details | | main (61880c7) | #553 (1faf912) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 34.8% | 34.8% | 0.0% |
| Files | 32 | 32 | 0 |
| Lines | 3467 | 3467 | 0 |
| Covered | 1207 | 1207 | 0 |
| Code to Test Ratio | 1:0.9 | 1:0.9 | 0.0 |
| Code | 7118 | 7118 | 0 |
| Test | 6969 | 6969 | 0 |
- | Test Execution Time | 10s | 11s | +1s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
prerelease_for_tagprinstalled gocredits at@latestthroughdepsdev, which resolved to v0.4.0 in the tagpr runs. v0.4.0 reads the module list from go.sum, so it also tries to credit modules that only the tests of dependencies need. It found no license for one of them and the command failed (run 34211030336).tagpr updated the release pull request anyway and the job stayed green, so CREDITS was never regenerated.
Change
A
creditstarget now installs gocredits pinned to v1.0.0 andprerelease_for_tagprcalls it. v1.0.0 collects modules withgo listover every platform instead of reading go.sum, so thego mod downloadstep and thedepsdevdependency go away. This follows k1LoW/octocov@c919651.depsdevstays as an empty target becausecistill depends on it.With v1.0.0 the next release pull request will drop 27 test-only modules from CREDITS (chromedp, testify, go-spew, gonum and so on) and add
go.yaml.in/yaml/v3, which the build does use.-skip-missingis not used because every module has a license gocredits can read. A new dependency without one will makemake creditsfail instead of being left out of CREDITS without a word.CI also needed a fix unrelated to CREDITS.
Homebrew/actionsno longer has amasterbranch, sosetup-homebrew@masterfailed the Test job before it started, on the dependabot pull requests as well. It now points atmain.