Repository navigation
Conversation
The `ptrInt64` helper in apply.go was annotated with `//go:fix inline`, so govet flagged its remaining callsite in table.go. Inline the call and drop the now-unused helper. Also convert the backward index loop in generateDeleteActions to `slices.Backward`, which modernize had flagged.
Contributor
Code Metrics Report
Details | | main (38d7305) | #524 (96e8372) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 33.7% | 33.7% | -0.1% |
| Files | 31 | 31 | 0 |
| Lines | 3407 | 3405 | -2 |
- | Covered | 1151 | 1150 | -1 |
+ | Code to Test Ratio | 1:0.9 | 1:0.9 | +0.0 |
| Code | 7022 | 7018 | -4 |
| Test | 6578 | 6578 | 0 |
- | Test Execution Time | 11s | 13s | +2s |Code coverage of files in pull request scope (28.1% → 28.0%)
Reported by octocov |
k1LoW
marked this pull request as ready for review
May 22, 2026 06:02
Merged
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
deck 1.24.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre><!-- Release notes generated using configuration in .github/release.yml at 7d1e45da428a62b61fe637a1f94615a9a55c9e90 --> ## What's Changed ### New Features 🎉 * feat: reserve "key" field in page configuration for stable slide referencing by @k1LoW in k1LoW/deck#527 ### Other Changes * chore(deps): bump the dependencies group with 4 updates by @dependabot[bot] in k1LoW/deck#507 * chore(deps): bump the dependencies group with 4 updates by @dependabot[bot] in k1LoW/deck#509 * chore(deps): bump google.golang.org/api from 0.273.0 to 0.274.0 in the dependencies group by @dependabot[bot] in k1LoW/deck#510 * chore(deps): bump the dependencies group with 2 updates by @dependabot[bot] in k1LoW/deck#511 * chore(deps): bump the dependencies group with 2 updates by @dependabot[bot] in k1LoW/deck#512 * chore(deps): bump the dependencies group with 3 updates by @dependabot[bot] in k1LoW/deck#513 * chore(deps): bump the dependencies group across 1 directory with 2 updates by @dependabot[bot] in k1LoW/deck#518 * chore(deps): bump the dependencies group across 1 directory with 4 updates by @dependabot[bot] in k1LoW/deck#519 * chore(deps): bump the dependencies group with 3 updates by @dependabot[bot] in k1LoW/deck#520 * chore(deps): bump the dependencies group with 3 updates by @dependabot[bot] in k1LoW/deck#521 * fix: resolve govet inline and modernize lint errors by @k1LoW in k1LoW/deck#524 * chore(deps): bump the dependencies group with 2 updates by @dependabot[bot] in k1LoW/deck#522 * chore(deps): bump the dependencies group across 1 directory with 3 updates by @dependabot[bot] in k1LoW/deck#528 * chore(deps): bump goreleaser/goreleaser-action from 7.2.1 to 7.2.2 in the dependencies group by @dependabot[bot] in k1LoW/deck#525 **Full Changelog**: https://github.com/k1LoW/deck/compare/v1.23.1...v1.24.0</pre> <p>View the full release notes at <a href="https://github.com/k1LoW/deck/releases/tag/v1.24.0">https://github.com/k1LoW/deck/releases/tag/v1.24.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!9957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lintwas failing on two issues:table.go:435— govetinlineflaggedptrInt64(0)becauseptrInt64inapply.gois annotated with//go:fix inline.action.go:657— modernizeslicesbackwardflagged the manual reverse index loop ingenerateDeleteActions.Changes:
ptrInt64(0)callsite intable.gotonew(int64)and remove the now-unused helper fromapply.go.generateDeleteActionsusingslices.Backward.Verified with
make lint(0 issues) andgo test ./...(all packages pass).