Skip to content

Goreleaser brew support - #24

Merged
jckuester merged 6 commits into
jckuester:masterfrom
rothgar:goreleaser-brew
Dec 19, 2020
Merged

jckuester merged 6 commits into
jckuester:masterfrom
rothgar:goreleaser-brew

Conversation

@rothgar

@rothgar rothgar commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Here's a base template for homebrew support.

You can install it from my tap via brew install rothgar/tap/awsls I changed the owner back to you for this PR.

To make a release

  • export GITHUB_TOKEN with repo write access
  • run goreleaser release --rm-dist

I couldn't find where you're creating the existing changelogs. I added it in the template but we can remove it if you want to stick with your current method. I also added checksums.txt to be added to the releases. You can see how it looks for the release here https://github.com/rothgar/awsls/releases/tag/v1.16.0

We can also add Linux arm support if you'd like. Once macOS arm support lands in go we should be able to update goreleaser and add support there too.

Fixes #23

@jckuester

jckuester commented Dec 18, 2020 •

Copy link
Copy Markdown
Owner

I couldn't find where you're creating the existing changelogs.

I probably went with the goreleaser defaults. Let's use your template.

I also added checksums.txt to be added to the releases.

Haven't noticed that I didn't provide checksums, thanks for adding them.

We can also add Linux arm support if you'd like.

I once added arm, but overall release times were so slow and timed out in a previous goreleaser version (because binaries for awsls are huge) that I removed them. Let's add arm again.

@rothgar

rothgar commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

Are you running releases locally? Would you like me to add GitHub actions to build releases when you push a new tag?

@jckuester

Copy link
Copy Markdown
Owner

I guess, this would be great. I did it locally, because my automated releases with Travis were timing out. But AFAIR releases with a newer version of goreleaser have been much faster (not sure if that has been a bug).

@rothgar

rothgar commented Dec 19, 2020

Copy link
Copy Markdown
Contributor Author

I did a local build yesterday when testing the goreleaser template. It still took a long time, but I had a good nap 😴 😄

I'll add a github action to do the build. You'll just need to add the GITHUB_TOKEN to settings in this repo before it'll work. You can still do builds with goreleaser locally and --skip-publish to test it.

Comment thread .github/workflows/release.yml Resolved
@jckuester
jckuester self-requested a review December 19, 2020 13:13
@jckuester

jckuester commented Dec 19, 2020 •

Copy link
Copy Markdown
Owner

LGTM. Thanks for your contribution, Justin :)

- name: Set up Go
uses: actions/setup-go@v1
with:
go-version: 1.13.x

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to 1.15.x to match the travis build? (I can also do that after merge)

Comment thread .goreleaser.yml

brews:
- tap:
owner: rothgar

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this back to my user? (I can also do that after merge).

@jckuester
jckuester merged commit b1a85f5 into jckuester:master Dec 19, 2020
@rothgar

rothgar commented Dec 19, 2020

Copy link
Copy Markdown
Contributor Author

Sorry I didn't get a chance to finish it last night. I got an error in GitHub actions on my build so I'm not 100% sure this will work as intended yet.
I was going to have another look at the error tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homebrew installable?

2 participants

⌂ 换网址