Skip to content

Add FieldNameTag config - #64

Closed
mathewTH wants to merge 1 commit into
invopop:mainfrom
mathewTH:configured-tag-name
Closed

mathewTH wants to merge 1 commit into
invopop:mainfrom
mathewTH:configured-tag-name

Conversation

@mathewTH

@mathewTH mathewTH commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Allows field names to be based on a different tag. Json is still the default tag so this is not a breaking change. #28 (reply in thread)

Allows field names to be based on a different tag.
Json is still the default tag so this is not a breaking change.
invopop#28 (reply in thread)

@josearomeroj josearomeroj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samlown samlown added the needs tests Not enough tests for this to be accepted label Apr 4, 2023
@samlown

samlown commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Thanks! Seems good from the outset, but we'd need some tests to validate it works as expected.

@balki

balki commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

Thanks! Seems good from the outset, but we'd need some tests to validate it works as expected.

Added test here. Please take a look.

@samlown

samlown commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Added test here. Please take a look.

Awesome. I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs tests Not enough tests for this to be accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址