Write Events/Errors using select #7

Activity

1. nathany commented on Sep 4, 2013

   

   nathany

   on Sep 4, 2013

   Contributor

   More actions

   What would this look like? Same channels/API just without requiring a goroutine?
2. howeyc commented on Sep 4, 2013

   

   howeyc

   on Sep 4, 2013

   OwnerAuthor

   More actions

   Yes.
   On Sep 4, 2013 12:14 PM, "Nathan Youngman" notifications@github.com wrote:

   What would this look like? Same channels/API just without requiring a
   goroutine?

   —
   Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-23815989
   .
3. nathany commented on Jan 16, 2014

   

   nathany

   on Jan 16, 2014

   Contributor

   More actions

   Chime in for the os/notify API: http://goo.gl/MrYxyA
4. aktau commented on Jul 8, 2014

   

   aktau

   on Jul 8, 2014

   More actions

   I'm not sure what makes this single thread unfriendly? Why can't I do something like:

   func main() {
     // create watcher
     w.Add("./")
     for {
       select {
         case <-w.Events:
           // do stuff
         case <-w.Errors:
           // handle error
         case <-sig:
           // signal received, probably quit
       }
     }
   }

   👍React with 👍1Reacted by Torsten Bronger
5. nathany commented on Jul 8, 2014

   

   nathany

   on Jul 8, 2014

   Contributor

   More actions

   See https://code.google.com/p/go/issues/detail?id=8282#c4 for one issue when using code very similar to what you presented.

   If you want to take a closer look on multiple platforms, please report your findings at https://github.com/fsnotify/fsnotify/issues/new
6. aktau commented on Jul 8, 2014

   

   aktau

   on Jul 8, 2014

   More actions

   Right. I suppose this is only an issue on some platforms (old linux? I saw some mentioning of the lowest linux denominator being too low to stop this from happening). Anyway, I'll run it in a separate goroutine for the time being and monitor this space. I'd love to be able to safely use it in single-threaded mode. As it stands, it's not very obvious one needs to do this goroutine trick. Thanks for the update!
7. srinathh commented on Mar 15, 2015

   

   srinathh

   on Mar 15, 2015

   More actions

   At GopherCon India last month, Alan Shreve gave a talk on Principles of designing Go APIs with channels which i thought might be relevant for this issue in FSNotify since I too had to puzzle through the sources to check if it's using blocking channels... Specifically An API that sends an unbounded stream of values into a channel must document how it behaves for slow consumers
8. nathany commented on Mar 18, 2015

   

   nathany

   on Mar 18, 2015

   Contributor

   More actions

   @srinathh Thanks for the tip. Now that the videos are up, I'll be sure to watch that talk.
9. mcauto

   added a commit that references this issue on May 13, 2019

   first commit 🎉

   e1dc975
10. matthewmueller commented on May 17, 2020

    

    matthewmueller

    on May 17, 2020

    More actions

    Is this still an issue? golang/go#8282 (comment)

    If so, what would be the non-racey way of doing this?

    👀React with 👀2Reacted by Torsten Bronger and Vincent Bernat