Skip to content
This repository was archived by the owner on Jun 27, 2025. It is now read-only.

Add log-level and log-format flags to render - #346

Merged
jrasell merged 5 commits into
hashicorp:masterfrom
angrycub:f-render-log-level
Aug 19, 2020
Merged

jrasell merged 5 commits into
hashicorp:masterfrom
angrycub:f-render-log-level

Conversation

@angrycub

Copy link
Copy Markdown
Contributor

Render always emits logs in debug level and JSON format. Adding these flags to allow operators to change this up.

Defaulted to existing behavior, even though it is inconsistent with the defaults on other commands. Personally, I'd prefer to adopt the defaults the other commands use as the defaults for render, but that would be a breaking change.

@jrasell
jrasell force-pushed the f-move-all-the-things branch from e27084d to 3e376af Compare August 19, 2020 13:29
@jrasell jrasell closed this Aug 19, 2020
@jrasell jrasell reopened this Aug 19, 2020
@angrycub
angrycub changed the base branch from f-move-all-the-things to master August 19, 2020 13:54

@jrasell jrasell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the test.levant file or can that be removed from the PR?

@jrasell jrasell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasell
jrasell merged commit a915cf1 into hashicorp:master Aug 19, 2020
@angrycub
angrycub deleted the f-render-log-level branch August 21, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址