Skip to content

docs(watermarkimage): Add docs for the /watermarkimage endpoint - #226

Merged
h2non merged 1 commit into
h2non:masterfrom
Neurostep:docs/watermarkimage
Dec 17, 2018
Merged

h2non merged 1 commit into
h2non:masterfrom
Neurostep:docs/watermarkimage

Conversation

@Neurostep

Copy link
Copy Markdown
Contributor

Add documentation for the /watermarkimage endpoint

@Neurostep

Copy link
Copy Markdown
Contributor Author

Question to the @h2non : Does it make sense to add an ability to specify image from the file system as well?

@h2non

h2non commented Dec 17, 2018

Copy link
Copy Markdown
Owner

It does, in case you have -mount enabled. I think image source can be determined by the URL/path schema of the query param value. If it is a legit URL, load it remotely, otherwise try reading it locally if -mount is enabled.

Feel free to send another PR separately. Thanks!

@h2non
h2non merged commit a1bb2fd into h2non:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址