Skip to content

Fail gracefully when format=auto #309

Open

Description

@mrkurt

We're seeing images that fail on webp encoding, but work fine with just jpg. The actual issue is #270.

Is it possible to make imaginary fail gracefully and just return the jpeg data it has when this kind of error happens?

Activity

  1. self-assigned this
    on May 28, 2020
  2. h2non commented on Jun 7, 2020

    @h2non
    Owner

    #270 is fixed in v1.2.0, which uses bimg v1.1.0, by fallback to a default ICC profile if no one is specified.

    I will keep this issue open since it is still room for future improvement in the API behavior about the underlying idea of smarter format detection mechanism by inferring accepted image using Client Hints HTTP headers.

  3. h2non commented on Jun 7, 2020

    @h2non
    Owner

    Related feature proposal: #253

  4. n1bs commented on Jul 28, 2020

    @n1bs

    Hello,

    We seems facing same kind of problem. When trying to convert JPEG (160px x 21600px) into WebP - getting HTTP400 with this inside:
    {"message":"Error while processing the image: vips2webp: unable to encode","status":400}

    Would be great to fallback into JPEG in such cases instead of error.

    In our case we send requests with explicit type=webp in query string.

  5. h2non commented on Jul 28, 2020

    @h2non
    Owner

    Hello @n1bs!
    Can you provide some WebP image that is giving you trouble so I can reproduce? I assume you are running the v1.2.2.

    A fallback mechanism might be optimal in this case, but I'd rather prefer this behavior to be explicitly requested in the HTTP request contract.

    Something like overloading the current type query param to host multiple allowed formats with order preference could work nicely here: type=webp,jpeg.

    Would that work?

  6. mrkurt commented on Jul 28, 2020

    @mrkurt
    Author

    I managed to replicate this with a random jpeg: https://i.imgur.com/6gBwEjy.jpg

    The imaginary params were: /convert?url=https://i.imgur.com/6gBwEjy.jpg&stripmeta=true&type=webp&quality=80

    Type with multiple available formats would work great for me.

  7. n1bs commented on Jul 29, 2020

    @n1bs

    thanks for the test image, Kurt!

    @h2non thanks for the quick look into this! Just to confirm - we're running v1.2.2 and type=webp,jpeg would work great for us.

  8. h2non commented on Jul 29, 2020

    @h2non
    Owner

    Cool, I will try to ship this feature by the end of the week or early next week. Will keep things posted here!

  9. added a commit that references this issue on Aug 4, 2020
  10. h2non commented on Aug 4, 2020

    @h2non
    Owner

    A fix was pushed in v1.2.3 under Docker image tags latest, 1, and 1.2.3.

    There is no change required in terms of URL API consumption.
    In case the image encoding fails, it will transparently fall back to JPEG encoding.

    You can test it with:
    /convert?url=https://i.imgur.com/6gBwEjy.jpg&stripmeta=true&type=webp&quality=80

  11. added 2 commits that reference this issue on Aug 11, 2022
  12. tina-junold commented on Oct 23, 2026

    @tina-junold

    For anyone still following this: ideaplexus/imaginary 2.3.0, a maintained fork of imaginary (Docker images for amd64 and arm64 as ideaplexus/imaginary:2.3.0), answers with a JPEG if the encoder of WebP, AVIF, HEIF or JPEG XL fails on an image, instead of an error; see its FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址