Skip to content

Remove GetRecursivelyReferencedUsedFragments and SkipNode - #1143

Merged
Shane32 merged 4 commits into
developfrom
remove_recursive_fragment_visitor
Aug 13, 2024
Merged

Shane32 merged 4 commits into
developfrom
remove_recursive_fragment_visitor

Conversation

@Shane32

@Shane32 Shane32 commented Aug 13, 2024 •

Copy link
Copy Markdown
Member
  • The AuthorizationVisitorBase.GetRecursivelyReferencedUsedFragments method has been removed as ValidationContext now provides a overload to GetRecursivelyReferencedFragments which will only return fragments in use by the specified operation.
  • The AuthorizationVisitorBase.SkipNode method has been removed as ValidationContext now provides a ShouldIncludeNode method.

See below PR which added both methods in the main project:

Note:

  • Unreferenced fragment testing is present within AuthorizationTests.UnusedFragmentsAreIgnored
  • Skip/ignore testing is present within AuthorizationTests.SkipInclude

@Shane32 Shane32 added this to the 8.0 milestone Aug 13, 2024
@Shane32 Shane32 self-assigned this Aug 13, 2024
@Shane32
Shane32 requested a review from gao-artur August 13, 2024 02:24
@Shane32 Shane32 changed the title Remove GetRecursivelyReferencedUsedFragments Remove GetRecursivelyReferencedUsedFragments and SkipNode Aug 13, 2024
Comment thread docs/migration/migration8.md Resolved
Co-authored-by: Artur Gordashnikov <gao.artur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址