Repository navigation
fix: convert line endings of Dockerfile to linux - #952
Merged
Merged
Conversation
Member
|
This has a merge conflict. Once resolved, I'll merge it. |
Contributor
Author
Done |
Member
I'm guessing the image checksum logic isn't working and the images are getting rebuilt, so package versions are drifting on the tests. |
Contributor
Author
|
The update of The image checksum logic would work. But this need to upload the image to https://hub.docker.com/u/aelsabbahy and create a checksum file. The alternative with the ghcr is part of #901 |
aelsabbahy
approved these changes
Aug 29, 2024
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
convert from windows to linux line endings
how to find
find . -not -type d -exec file "{}" ";" | grep CRLF