Repository navigation
ci: add validation with yamllint - #951
Merged
Merged
Conversation
Member
|
Will this fail with files generated by goss. I recall a while back someone reporting goss generated yaml files don't pass yamllint. Goss uses the go yaml package and doesn't really attempt to manipulate it. |
Contributor
Author
|
When validating Go templates, similar problems occur as in:
That is th reason why there is a list of exceptions: ignore:
# uses go templates (these are invalid yaml files)
- integration-tests/goss/goss-service.yaml
- integration-tests/goss/goss-shared.yaml
- docs/goss.yamlWhat should be next?
|
1 of 3 tasks
aelsabbahy
approved these changes
Dec 26, 2024
aelsabbahy
left a comment
Member
There was a problem hiding this comment.
Not sure how I missed this, thought I merged it a while back.
Apologies for that and thanks for the great addition.
Need to fix the containers for CI the failure is not due to your change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
#568 adds an yamllint configuration. But it seems not to be used.
This adds a pipeline and fix a lot of issues.
📚 Documentation preview 📚: https://goss--951.org.readthedocs.build/en/951/