Repository navigation
fix integration tests for alpine3 - #937
Merged
Merged
Conversation
dklimpel
marked this pull request as ready for review
June 21, 2024 09:17
Member
|
Yeah, I think this is related to #149 My guess is travis-ci changed that setting in their CI runners. I'm not able to reproduce that behavior on my local machine and the CI used to work just fine.. so that's my theory. I added some debugging to my branch yesterday which showed that it was indeed listening to tcp6 here: https://app.travis-ci.com/github/goss-org/goss/jobs/623192771#L5295 This PR is the cleanest fix, so I'll merge this and close out the other ones. Great find and thanks for the elegant fix! |
Contributor
Author
|
I had a discussion with my colleague. One alternative is to switch from Apache2 to Nginx. Nginx runs on both ports, IPv4 and IPv6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Apache2 has only one listener by design. Either IPv4 or IPv6.
It seems that the order of the ip addresses has been changed (in CI/docker runtime). Previously IPv4 first to now IPv6 first. If the test with Apache2 should explicitly test IPv4, the service should also explicitly run on IPv4.
Related: