Skip to content

feat: s390x build option added to build package for IBM Z series - #863

Merged
aelsabbahy merged 4 commits into
goss-org:masterfrom
harpaldhillon:s390x-arch
Jan 26, 2024
Merged

aelsabbahy merged 4 commits into
goss-org:masterfrom
harpaldhillon:s390x-arch

Conversation

@harpaldhillon

@harpaldhillon harpaldhillon commented Jan 11, 2024 •

Copy link
Copy Markdown
Contributor

A new build option (release/goss-linux-s390x) is added in the Makefile to release package for s390x architecture.

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

A new build option (release/goss-linux-s390x) is added in the Makefile to release package for s390x architecture.

@harpaldhillon harpaldhillon changed the title feat: s390x build option added to build packages for IBM Z series feat: s390x build option added to build package for IBM Z series Jan 11, 2024
@aelsabbahy

Copy link
Copy Markdown
Member

Sorry for the delay, I recently had a newborn so been busy.

This looks good, just need to update the .travis.yaml to ensure those binaries are published as part of the release.

For my own education/growth, do all goss features work out the box for s390x? or does it only partially work? Wondering if it should be a standard release or something in the multi-os support section.

@harpaldhillon

Copy link
Copy Markdown
Contributor Author

Many congratulations @aelsabbahy on your newborn baby.

Thanks, changes are now pushed to .travis.yaml file.

Also, we run around 175 goss tests based on CIS benchmarks and all these successfully passed on s390x machine. I think it can be part of standard release.

@aelsabbahy aelsabbahy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to submit this. Should be in the next Goss release.

@aelsabbahy
aelsabbahy merged commit 9ae6acf into goss-org:master Jan 26, 2024
@harpaldhillon
harpaldhillon deleted the s390x-arch branch January 27, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址