Skip to content

Fix the main CI pipelines - #1063

Merged
aelsabbahy merged 1 commit into
goss-org:masterfrom
kgaughan:unbreak-the-pipelines-phase-1
Jun 8, 2026
Merged

aelsabbahy merged 1 commit into
goss-org:masterfrom
kgaughan:unbreak-the-pipelines-phase-1

Conversation

@kgaughan

@kgaughan kgaughan commented Jun 8, 2026 •

Copy link
Copy Markdown
Collaborator
Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

  • Relevant actions upgraded
  • The integration test pipeline now pulls from ghcr.io where it can.
  • Linux integration tests now run in parallel with the Windows and MacOS tests.
  • dnstest.io tests now use a zone hosted locally dnsmasq, unbreaking all DNS-related integration tests. All images now include dnsmasq and have been updated to reasonably recent versions of each target OS
  • CentOS 7 is removed.
  • Improved ArchLinux support: still not on par with everything else just yet, but it's not as much of a special case.
  • Support for overriding the use of docker in test.sh
  • Image builds use the --file flag for specifying the dockerfile rather than piping it in. This gets rid of some weird behaviours I encountered when building images.
  • release-build.sh now leans on git describe to get the release tag name.
  • Use -trimpath to avoid incorporating build context into binaries: this makes the build more stable.

I'm temporarily leaving in the MD5 check in integration-tests/test.sh, but I think it should ultimately be removed once new integration test runner images are built.

I've kept any dependency/toolchain updates out of this as they introduce changes to some of the diagnostic output that breaks the tests. That can be handled separately.

Closes #1059, #1061.

Summary:

 * Relevant actions upgraded
 * The integration test pipeline now pulls from ghcr.io where it can.
 * Linux integration tests now run in parallel with the Windows and
   MacOS tests.
 * dnstest.io tests now use a zone hosted locally dnsmasq, unbreaking
   all DNS-related integration tests. All images now include dnsmasq and
   have been updated to reasonably recent versions of each target OS
 * CentOS 7 is removed.
 * Improved ArchLinux support: still not on par with everything else
   just yet, but it's not as much of a special case.
 * Support for overriding the use of `docker` in `test.sh`
 * Image builds use the `--file` flag for specifying the dockerfile
   rather than piping it in. This gets rid of some weird behaviours
   I encountered when building images.
 * `release-build.sh` now leans on `git describe` to get the release tag
   name.
 * Use `-trimpath` to avoid incorporating build context into binaries:
   this makes the build more stable.

I'm temporarily leaving in the MD5 check in `integration-tests/test.sh`,
but I think it should ultimately be removed once new integration test
runner images are built.

I've kept any dependency/toolchain updates out of this as they introduce
changes to some of the diagnostic output that breaks the tests. That can
be handled separately.
@kgaughan
kgaughan requested a review from aelsabbahy as a code owner June 8, 2026 14:19
@kgaughan kgaughan mentioned this pull request Jun 8, 2026
kgaughan added a commit to kgaughan/joss that referenced this pull request Jun 8, 2026
Some package versions have changed.
@aelsabbahy

Copy link
Copy Markdown
Member

Once this is merged. What's the process for publishing/updating the images?

@aelsabbahy

Copy link
Copy Markdown
Member

Oh, and many thanks for doing this. Much appreciated!

@aelsabbahy
aelsabbahy merged commit 3cae74d into goss-org:master Jun 8, 2026
7 checks passed
@aelsabbahy

Copy link
Copy Markdown
Member

https://github.com/goss-org/goss/actions/runs/27158027185

@kgaughan
kgaughan deleted the unbreak-the-pipelines-phase-1 branch June 8, 2026 19:23
@kgaughan

kgaughan commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

I'll rebase my remaining branches, starting with the dependency updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址