You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Either drop file/size from add/autoadd OR add md5 and sha to it. #262
So the opposite exists today in Goss with --exclude-attr. There could be an --include-xtra-attr global flag that does this.
That said, to your point about "simpler." It really comes down to what would the majority of users expect from a goss add file. My gut tells me @pysysops is right with just sha256, but no size.
I think it comes down to whether or not a file is expected to change very often. While I enjoy a special love for the sha256 test, I cannot claim one way or the other that static files are the target of the majority use case.
Activity
pysysops commentedon Aug 6, 2017
SHA-256 may be the most sensible and current attribute to default to? Especially with the recent (last year or so) posts about SHA-1 / MD5 collisions.
aelsabbahy commentedon Aug 6, 2017
If one of them were to stay sha256 makes the most sense.
I'm just not sure if sha256 by default is a useful addition or an annoyance (generated test too rigid).
I can go either way on this one. Drop them all, add them all, or only keep sha256.
elliotweiser commentedon Aug 6, 2017
When deciding on defaults, it's often best to go the "simpler" route.
IMO, it's best to use none of those checks and to let the user decide what he/she wants to add.
Perhaps this opens the door on supporting additional flags to
goss addfor thefiletest, e.g.--checksum. Thoughts?aelsabbahy commentedon Aug 6, 2017
So the opposite exists today in Goss with
--exclude-attr. There could be an--include-xtra-attrglobal flag that does this.That said, to your point about "simpler." It really comes down to what would the majority of users expect from a
goss add file. My gut tells me @pysysops is right with just sha256, but no size.elliotweiser commentedon Aug 6, 2017
I think it comes down to whether or not a file is expected to change very often. While I enjoy a special love for the sha256 test, I cannot claim one way or the other that static files are the target of the majority use case.
aelsabbahy commentedon Aug 7, 2017
Yeah, that's what bother me about size. It's such a flakey test, but with even less value than sha256.
Maybe less is more. Keep all the "extra" tests as manual.
elliotweiser commentedon Aug 7, 2017
FWIW, I wouldn't be opposed to switching out
sizewithsha256to see what kind of feedback it generates.aelsabbahy commentedon Dec 14, 2019
Deciding to drop size
Fix #262 no need to add file size by default
POC/DRAFT: Add transforms (#576)
V4 new (goss-org#814)