Repository navigation
Fix some order dependent tests - #83
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 142 142
=========================================
Hits 142 142 |
Member
|
Thank you for this fix. |
emrelab
added a commit
to emrelab/go-flake-hunter
that referenced
this pull request
Nov 10, 2026
* docs: correct release status and explain value * ci: detect documentation drift against binary * docs: stop claiming unmerged upstream fixes landed The README's stat line said 'two real upstream bugs reduced and fixed'. Only one of the two is merged upstream: gosimple/slug#83 landed in 2024, while CLIProxyAPI#7356 is an open proposal applied locally. The same overclaim sat in the case table ('fix validated') and in the real-world index ('Upstream fix'). Say what is true: these are witnesses, not discoveries, and the table now distinguishes a merged fix from an open proposal. A visitor who checks the PR links finds agreement instead of a retraction. --------- Co-authored-by: Yunus Emre Karaman <176586976+emrelab@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were modifying global state and not resetting it. Clearing the CustomSub lets the tests run in any order.