Skip to content

Fix some order dependent tests - #83

Merged
matrixik merged 1 commit into
gosimple:masterfrom
vannem-sj:master
Feb 23, 2024
Merged

matrixik merged 1 commit into
gosimple:masterfrom
vannem-sj:master

Conversation

@vannem-sj

Copy link
Copy Markdown
Contributor

These tests were modifying global state and not resetting it. Clearing the CustomSub lets the tests run in any order.

@codecov

codecov Bot commented Sep 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #83 (91ec822) into master (1eab316) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          142       142           
=========================================
  Hits           142       142           

@matrixik matrixik added the tests label Feb 23, 2024
@matrixik
matrixik merged commit 76470d7 into gosimple:master Feb 23, 2024
@matrixik

Copy link
Copy Markdown
Member

Thank you for this fix.

emrelab added a commit to emrelab/go-flake-hunter that referenced this pull request Nov 10, 2026
* docs: correct release status and explain value

* ci: detect documentation drift against binary

* docs: stop claiming unmerged upstream fixes landed

The README's stat line said 'two real upstream bugs reduced and fixed'. Only
one of the two is merged upstream: gosimple/slug#83 landed in 2024, while
CLIProxyAPI#7356 is an open proposal applied locally. The same overclaim sat in
the case table ('fix validated') and in the real-world index ('Upstream fix').

Say what is true: these are witnesses, not discoveries, and the table now
distinguishes a merged fix from an open proposal. A visitor who checks the PR
links finds agreement instead of a retraction.

---------

Co-authored-by: Yunus Emre Karaman <176586976+emrelab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址