Skip to content

Correct substitution for bulgarian 'Щ' - #80

Merged
matrixik merged 1 commit into
gosimple:masterfrom
kvalev:patch-1
Feb 23, 2024
Merged

matrixik merged 1 commit into
gosimple:masterfrom
kvalev:patch-1

Conversation

@kvalev

@kvalev kvalev commented May 18, 2023

Copy link
Copy Markdown
Contributor

Probably due to a copy-paste error the substitution for Ш and Щ was identical, but only for the uppercase variants.

@codecov

codecov Bot commented May 26, 2023 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (76470d7) to head (d923cc0).

❗ Current head d923cc0 differs from pull request most recent head b33dd82. Consider uploading reports for the commit b33dd82 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          119       142   +23     
=========================================
+ Hits           119       142   +23     
Files Coverage Δ
languages_substitution.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@kvalev

kvalev commented May 30, 2023

Copy link
Copy Markdown
Contributor Author

@matrixik Can you take a look when you get the chance?

@matrixik matrixik added the bug label Feb 23, 2024
@matrixik
matrixik merged commit 78044c1 into gosimple:master Feb 23, 2024
@matrixik

Copy link
Copy Markdown
Member

Thank you for your fix and sorry it took so long.

@kvalev
kvalev deleted the patch-1 branch February 28, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址