Skip to content

New language: hu/hun/hungarian - #65

Merged
matrixik merged 3 commits into
gosimple:masterfrom
theriverman:master
Dec 13, 2021
Merged

matrixik merged 3 commits into
gosimple:masterfrom
theriverman:master

Conversation

@theriverman

Copy link
Copy Markdown
Contributor

Adding support for the Hungarian (hu/hun) language

@codecov

codecov Bot commented Dec 13, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #65 (a17f6e3) into master (f347b0c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a17f6e3 differs from pull request most recent head bbbac16. Consider uploading reports for the commit bbbac16 to get more accurate results

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          135       135           
=========================================
  Hits           135       135           
Impacted Files Coverage Δ
languages_substitution.go 100.00% <100.00%> (ø)
slug.go 100.00% <100.00%> (ø)

@matrixik

matrixik commented Dec 13, 2021 •

Copy link
Copy Markdown
Member

I saw that you did not add substitutions for & and @ so they will follow English (default) substitutions: '&' => "and", '@' => "at".

Thank you for this changes.

@matrixik
matrixik merged commit e104167 into gosimple:master Dec 13, 2021
@theriverman

Copy link
Copy Markdown
Contributor Author

I saw that you did not add substitutions for & and @ so they will follow English (default) substitutions: '&' => "and", '@' => "at".

Thank you for this changes.

We don’t really use & in Hungarian so the English substitution will be alright. The slug will remain readable for native speakers. Same applies to @.
If others disagree, we can come back later and figure out something :)

Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址