Skip to content

Code panics for Unicode U+10000 #53

Closed

Description

@tja

This code panics:

slug.Make("𐀀")

This is due to the internal use of rainycape/unidecode, which can not handle Unicode character U+10000, see rainycape/unidecode#8.

Given the inactivity of the upstream package, it might be worth filtering out the character in question before passing it to unidecode.

Activity

  1. added a commit that references this issue on Jul 26, 2021
    a0807d1
  2. matrixik commented on Jul 26, 2021

    @matrixik
    Member

    Thank you for this report and sorry it took so long, burnout is not nice...

    I forked https://github.com/rainycape/unidecode to https://github.com/gosimple/unidecode and fixed this issue.

  3. tja commented on Jul 26, 2021

    @tja
    Author

    Thanks a bunch for the fix.. I really appreciate it.

    Sorry to hear about your burnout — I hope you're doing better now!

  4. matrixik commented on Jul 26, 2021

    @matrixik
    Member

    I'm definitely better now, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址