You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Graceful shutdown of the websocket connection. #448
It seems like to achieve a "normal" shutdown of a websocket connection, one needs to do a dance like:
Send Close message
Wait for receiving a Close message
Actually close the connection
The Close method of today closes the connection immediately, without warning or graceful shutdown. Would it be desirable to have a Shutdown method like golang's http servers, which does the dance explained above for the user?
Reacted by Andrew, Jonathan Chappelow, Fabian Weisshaar, gaborigloi, Jordan, Patrik, Dario Emerson, 懒人旭, Borys Hulii, SystemGlitch and 15 more
Activity
ankur0493 commentedon Dec 6, 2018
@garyburd Can you please assign this issue to me. I would like to work on it.
elithrar commentedon Dec 10, 2018
ankur0493 commentedon Dec 11, 2018
Thanks @garyburd. Will soon share the API details.
gracefully close connection fixes: gorilla#448
gracefully close connection fixes: gorilla#448
gracefully close connection fixes: gorilla#448
gracefully close connection fixes: gorilla#448
nhooyr commentedon Oct 9, 2019
For someone who wants this now, I've implemented it in nhooyr.io/websocket@v1.7.0
See discussion in coder/websocket#160
jaitaiwan commentedon Jun 19, 2024
@canelohill @tebuka would be good to get your thoughts on this PR.
usmanovbf commentedon Oct 20, 2024
Hi there! is it still actual?
fix: Ensure all connections persist until queue-proxy drain
fix: Ensure all connections persist until queue-proxy drain