Repository navigation
refactor(deps): move HIBP client into pkg/hibp to break the module cycle - #3603
Merged
Merged
Conversation
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
gopass required gopass-hibp while gopass-hibp required gopass, forming a
module-level dependency cycle that made releases circular and tooling
noisy.
Move the HIBP client packages into this module as pkg/hibp/{api,dump}.
They move verbatim because their only gopass dependencies (pkg/debug,
pkg/fsutil, pkg/ctxutil, pkg/termio) live in the same module now.
internal/audit imports them locally and the gopass-hibp module
requirement is no longer needed.
The standalone gopass-hibp binary stays in its own repository and will
be repointed at gopass/pkg/hibp in a follow-up.
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gopass required gopass-hibp while gopass-hibp required gopass, forming a
module-level dependency cycle that made releases circular and tooling
noisy.
Move the HIBP client packages into this module as pkg/hibp/{api,dump}.
They move verbatim because their only gopass dependencies (pkg/debug,
pkg/fsutil, pkg/ctxutil, pkg/termio) live in the same module now.
internal/audit imports them locally and the gopass-hibp module
requirement is no longer needed.
The standalone gopass-hibp binary stays in its own repository and will
be repointed at gopass/pkg/hibp in a follow-up.