Skip to content

refactor(deps): move HIBP client into pkg/hibp to break the module cycle - #3603

Merged
dominikschulz merged 2 commits into
gopasspw:masterfrom
dominikschulz:feat/movehibp
Sep 10, 2026
Merged

dominikschulz merged 2 commits into
gopasspw:masterfrom
dominikschulz:feat/movehibp

Conversation

@dominikschulz

Copy link
Copy Markdown
Member

gopass required gopass-hibp while gopass-hibp required gopass, forming a
module-level dependency cycle that made releases circular and tooling
noisy.

Move the HIBP client packages into this module as pkg/hibp/{api,dump}.
They move verbatim because their only gopass dependencies (pkg/debug,
pkg/fsutil, pkg/ctxutil, pkg/termio) live in the same module now.
internal/audit imports them locally and the gopass-hibp module
requirement is no longer needed.

The standalone gopass-hibp binary stays in its own repository and will
be repointed at gopass/pkg/hibp in a follow-up.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
gopass required gopass-hibp while gopass-hibp required gopass, forming a
module-level dependency cycle that made releases circular and tooling
noisy.

Move the HIBP client packages into this module as pkg/hibp/{api,dump}.
They move verbatim because their only gopass dependencies (pkg/debug,
pkg/fsutil, pkg/ctxutil, pkg/termio) live in the same module now.
internal/audit imports them locally and the gopass-hibp module
requirement is no longer needed.

The standalone gopass-hibp binary stays in its own repository and will
be repointed at gopass/pkg/hibp in a follow-up.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added cleanup Code hygiene dependencies Pull requests that update a dependency file labels Sep 10, 2026
@dominikschulz
dominikschulz merged commit d6bf336 into gopasspw:master Sep 10, 2026
9 checks passed
@dominikschulz
dominikschulz deleted the feat/movehibp branch September 10, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code hygiene dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址