Repository navigation
fix: require --age-sshkeys (or age.sshkeys config) to access ~/.ssh - #3525
Conversation
|
The revised documentation tries to make it clear that |
|
Confusing that some tests fail like this: The calls to |
dominikschulz
left a comment
There was a problem hiding this comment.
Looks pretty good, just some small nits. Thanks!
| func TestInitialized(t *testing.T) { | ||
| ctx := t.Context() | ||
| a, err := New(ctx, "") | ||
| a, err := New(ctx, false, "") |
There was a problem hiding this comment.
I don't see what's wrong here right now, but we need to fix this before we can merge the PR.
There was a problem hiding this comment.
Smells some cache somewhere. But that also does not make sense to me in this case.
7aaab8e to
bc3715a
Compare
|
CodeQL CI step also fails: |
|
@quite The CodeQL CI failure shouldn't be your concern. But I'm worried about the other builds failing. Please don't spend too much time on this. I've merged over a dozen pending PRs yesterday. Maybe some GitHub Action broke something. I'll try to take a look at that soon. But if you find the root cause, that would help 😄 |
0e7cd27 to
89e3c9f
Compare
|
Last forcepush fixes in commands.go so that |
This makes actual functionality follow status quo documentation. Also does not access ~/.ssh unless user ir explicit about that. If age.ssh-key-path is set, it is loaded in addition to age.sshkeys, if that is enabled, or instead of those, if not. Fixes gopasspw#3522 Signed-off-by: Daniel Lublin <daniel@lublin.se>
|
I can't reproduce the test failures locally and most of the other failing actions should have been fixed by other PRs. So I'm going ahead and merge this. |
- c4991b9 Personalize module - 61e6a7b chore(deps): bump github.com/schollz/closestmatch (gopasspw#3573) - d116888 chore(deps): bump github.com/urfave/cli/v3 from 3.10.1 to 3.11.0 (gopasspw#3574) - 4b130a7 chore(deps): bump github.com/noborus/ov from 0.45.1 to 0.54.0 (gopasspw#3571) - 48b02d9 chore(deps): bump the golang-x group with 3 updates (gopasspw#3570) - 266d033 chore(deps): bump github.com/zalando/go-keyring from 0.2.6 to 0.2.8 (gopasspw#3572) - 6315226 chore(deps): bump github.com/stretchr/testify from 1.12.0 to 1.12.1 (gopasspw#3575) - 486817a fix(setup): rename --alias/--create to --team/--create-team (gopasspw#3568) - 2d0e678 fix(age): deterministically order identities for decryption (gopasspw#3566) - 99c901f chore: Update FAQ entry about binary commands (gopasspw#3567) - c6a36f5 fix(age): only encrypt for recipients in .age-recipients (gopasspw#3564) - 191f850 chore(termio): Check gitconfig after Git env vars (gopasspw#3562) - f4f2d9a chore: Fix age tests (gopasspw#3561) - 867f54d tools: add SSA semantic duplicate analyzer (gopasspw#3558) - 19e4aa4 fix: require --age-sshkeys (or age.sshkeys config) to access ~/.ssh (gopasspw#3525) - 2b095cb refactor(age): share identity file parsing (gopasspw#3559) - f4a6c85 chore(deps): bump github/codeql-action/upload-sarif (gopasspw#3550) - be89f24 chore(deps): bump github.com/ProtonMail/go-crypto from 1.3.0 to 1.4.1 (gopasspw#3548) - 24d777e chore(deps): bump the terminal group across 1 directory with 4 updates (gopasspw#3542) - 9180536 chore(deps): bump github.com/gopasspw/gopass-hibp from 1.15.18 to 1.16.1 (gopasspw#3549) - 26fca24 chore(deps): bump the golang-x group across 1 directory with 6 updates (gopasspw#3541) - bad4c15 chore(deps): bump github/codeql-action/init from 4.37.3 to 4.37.7 (gopasspw#3554) - fd0ff4e chore(deps): bump step-security/harden-runner from 2.20.0 to 2.20.1 (gopasspw#3556) - 73c7fb5 chore(deps): bump github.com/stretchr/testify from 1.11.1 to 1.12.0 (gopasspw#3546) - 8b2fe80 chore(deps): bump github.com/urfave/cli/v3 from 3.9.0 to 3.10.1 (gopasspw#3547) - 052fffe chore(deps): bump github/codeql-action/autobuild from 4.37.3 to 4.37.7 (gopasspw#3553) - 5e0532e chore(deps): bump github/codeql-action/analyze from 4.37.3 to 4.37.7 (gopasspw#3555) - cacbc23 test(gpg): isolate package GnuPG home (gopasspw#3557) - 1a8eff0 docs: replace retired Go Report Card badge with golangci-lint CI badge (gopasspw#3560) - f17aff3 ci: update golangci-lint to v2.13.1 and migrate gomodguard (gopasspw#3498) - d0bb2fe fix: eliminate audit, queue, and test initialization races (gopasspw#3540) - 6eaa853 chore(deps): bump github.com/twpayne/go-pinentry/v4 from 4.0.0 to 4.0.1 (gopasspw#3543) - 38ae9ce chore(deps): bump github.com/godbus/dbus/v5 from 5.1.0 to 5.2.2 (gopasspw#3551) - 6522e82 chore(deps): bump go.yaml.in/yaml/v3 from 3.0.4 to 3.0.5 (gopasspw#3552) - d5a7cb1 ci: restore security workflow reliability (gopasspw#3538) - 1ac7645 ci(deps): add gomod ecosystem, cooldown and grouping to dependabot (gopasspw#3501) - 276de5e ci: pin dependabot/fetch-metadata by SHA and annotate action versions (gopasspw#3500) - 38f9248 fix(updater): cap archive/icon extraction writes and surface oversize errors (gopasspw#3530) - 1a0ecb4 fix: honor core.autopush during root-store move operations (gopasspw#3535) - 402c780 fix: highlight linked secrets in ls output (gopasspw#3536) - a86172d chore(updater): Add 2026 release signing key (gopasspw#3534) - 7ab7ba2 fix(pwgen): remove math/rand fallback (gopasspw#3531) - de38cfa fix: add hidden pull and push commands (gopasspw#3532) - c4fa655 ci(updater): move key expiration canary test to dedicated workflow (gopasspw#3533) - f697302 fix: drain background queue before exiting on failure (gopasspw#3528) - d060513 fix(age): raise agent scanner buffer limit to handle large decrypt payloads (gopasspw#3529) - 7cef068 test(action): use t.Chdir instead of manual os.Chdir save/restore (gopasspw#3499) - 7ce984e fix(tempfile): mount macOS ramdisk read-write (gopasspw#3527) - 4f76ed5 Merge commit from fork - ebc51bd feat(gpg): support v5/v6 PGP keys with 64-character fingerprints (gopasspw#3496) - 5ce247f docs: point Android clients to the maintained agrahn fork (gopasspw#3524) - a938330 chore(deps): bump msys2/setup-msys2 from 2.31.1 to 2.32.0 (gopasspw#3475) - 2c290d9 chore(deps): bump golang.org/x/crypto from 0.45.0 to 0.52.0 (gopasspw#3490) - 0ad084f fix: use imperative mood in generated commit messages (gopasspw#3492) - 9c71d39 feat(pwgen): add memorable generator support (gopasspw#3494) - cb53065 feat(changelog): migrate to Keep a Changelog 1.1.0 (gopasspw#3506) - fa4e267 docs(adr): resolve the A-13 collision, zero-pad numbers and add an index (gopasspw#3502) - dda7b30 docs: add docs/conventions.md and adopt Conventional Commits (gopasspw#3503) - 0c0193a fix(age): send agent identities space-separated on a single line (gopasspw#3509) - 33b281f chore(deps): bump docker/metadata-action from 6.1.0 to 6.2.0 (gopasspw#3511) - 242e80c chore(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4 (gopasspw#3514) - 759e0e4 chore(deps): bump step-security/harden-runner from 2.19.4 to 2.20.0 (gopasspw#3515) - 2044f29 chore(deps): bump github/codeql-action/analyze from 4.36.1 to 4.37.3 (gopasspw#3516) - e398dd3 age: don't assumes `os.Args[0]` implements the `age agent start` subcommand (gopasspw#3510) - 8323266 chore(deps): bump actions/setup-go from 6.4.0 to 7.0.0 (gopasspw#3518) - 24688f3 chore(deps): bump github/codeql-action/upload-sarif (gopasspw#3519) - ffb65fb chore(deps): bump actions/checkout from 7.0.0 to 7.0.1 (gopasspw#3512) - b7a7c72 chore(deps): bump docker/login-action from 4.2.0 to 4.6.0 (gopasspw#3520) - eb1368e fix: Avoid NPE when attempting to edit a non-existing secret (gopasspw#3489) - 4be016b fix(age): recover agent on missing identities, not only when locked (gopasspw#3488) - 75fa797 fix(age): expand ~/ in age.ssh-key-path (gopasspw#3474) - c1cb9c1 chore(deps): bump goreleaser/goreleaser-action from 7.2.2 to 7.2.3 (gopasspw#3479) - 743560b chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0 (gopasspw#3481) - 1fa2563 chore(deps): bump actions/cache from 5.0.5 to 6.1.0 (gopasspw#3484) - a31073b chore(deps): bump docker/build-push-action from 7.2.0 to 7.3.0 (gopasspw#3480) - 6bf7259 chore(deps): bump actions/checkout from 6.0.3 to 7.0.0 (gopasspw#3485) - f25fc7b fix: restore clip flag through fuzzy search in show command (gopasspw#3466) - 837919a fscopy: derive copy direction from the source argument (gopasspw#3462) - ae9e8e2 chore(deps): bump docker/build-push-action from 7.1.0 to 7.2.0 (gopasspw#3455) - 7a99585 fix: Disable grype, the builder seems to be broken (gopasspw#3463) - 7fd76df feat(show): add configurable fuzzy-search fallback toggle (gopasspw#3449) - e7d27b4 Improve Team Workflows (gopasspw#3460) - 74da9bb chore(deps): bump github/codeql-action from 4.35.3 to 4.36.1 (gopasspw#3456) - 9821111 chore(deps): bump sigstore/cosign-installer from 4.1.1 to 4.1.2 (gopasspw#3457) - ef6f97b chore(deps): bump actions/checkout from 6.0.2 to 6.0.3 (gopasspw#3458) - ae54506 chore(deps): bump docker/login-action from 4.1.0 to 4.2.0 (gopasspw#3459) - 9dc1199 chore(deps): bump goreleaser/goreleaser-action from 7.2.1 to 7.2.2 (gopasspw#3454) - 99439e3 chore(deps): bump golangci/golangci-lint-action from 9.2.0 to 9.2.1 (gopasspw#3453) - 16c6190 chore(deps): bump docker/metadata-action from 6.0.0 to 6.1.0 (gopasspw#3452) - 801e1a4 chore(deps): bump step-security/harden-runner from 2.19.0 to 2.19.4 (gopasspw#3451) - 8d9d1a3 otp: hide --snip flag when built with noscreenshot tag (gopasspw#3445) - 804c5ba fix: clip flag (-c) for cli/v3 GenericFlag compatibility (gopasspw#3448) - 09ea770 fix: store mount paths relative to home dir for cross-platform portability (gopasspw#3439) - 66cd21c otp: add noscreenshot build tag and document screen-capture scope (gopasspw#3442) - bb7ecbb fix: warn when recipient key is expired or unusable during encryption (gopasspw#3443) - 0d41c38 fix: update bash completion flag for urfave/cli/v3 compatibility (gopasspw#3441) - 2891435 [chore] Update gopasspw/clipboard (gopasspw#3436) - f5132c1 [chore] Document stability for pkg/gopass (gopasspw#3438) - 5bde6f5 Add ADR-11 (gopasspw#3437) - 7fa5aa0 chore: More output before and after long running release ops (gopasspw#3433) - 4599b40 Improve pre-release support (gopasspw#3432) - bcd7435 Add CI-aware release signing and cosign verification docs (gopasspw#3431) - fddf2d1 bug: reload identities on unlock command (gopasspw#3430) - 100194d Warn when keyring is unavailable (gopasspw#3429) - 7c63ba0 chore(deps): migrate from urfave/cli v2 to v3 (gopasspw#3428) - f25921e fix: Configure .gitattributes based on the backend (gopasspw#3427) - 3be73b2 fix: add case-insensitive secret name normalization (gopasspw#3390) - 014d456 fix(copy): preserve directory structure when copying with trailing slash (gopasspw#3396) - 3b16cb2 [chore] Follow up to PR 3383 (gopasspw#3410) - 578a14a [fix] Support HW Age identities (gopasspw#3389) - ac6114f docs(architecture): add API Stability section clarifying module semver policy (gopasspw#3422) - f4ed69c docs(appdir): explain GOPASS_HOMEDIR override in UserHome comment (gopasspw#3421) - d978513 fix(secparse): replace panic in MustParse with testing.TB.Fatalf (gopasspw#3420) - ec666a0 chore(deps): bump github/codeql-action from 4.35.1 to 4.35.3 (gopasspw#3401) - 371990f age: fix YubiKey identity persistence via raw-append (ADR-0002) (gopasspw#3399) - 49abf9c fix(backend): add storage.backend config key to lock backend selection (gopasspw#3332) (gopasspw#3398) - 22b84a8 fix(setup): suppress auto-commit in gitfs when setup remote is specified (gopasspw#2901) (gopasspw#3391) - eb656fd chore(deps): bump goreleaser/goreleaser-action from 7.0.0 to 7.2.1 (gopasspw#3402) - fb66ed3 chore(deps): bump docker/login-action from 4.0.0 to 4.1.0 (gopasspw#3400) - 0a1e293 chore(deps): bump step-security/harden-runner from 2.16.1 to 2.19.0 (gopasspw#3405) - 20097cf chore(deps): bump actions/cache from 5.0.4 to 5.0.5 (gopasspw#3404) - 846094d chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1 (gopasspw#3403) - 7967f9c chore(deps): bump msys2/setup-msys2 from 2.31.0 to 2.31.1 (gopasspw#3408) - b928cc2 chore(deps): bump dependabot/fetch-metadata from 2 to 3 (gopasspw#3406) - 2b1eece chore(deps): bump docker/build-push-action from 7.0.0 to 7.1.0 (gopasspw#3407) - 721ff8a fix(age-agent): handle AGE-PLUGIN-* identities to fix 'malformed secret key: mixed case' error (gopasspw#3397) - a793b7b feat: support -c=N to copy specific line to clipboard (gopasspw#3386) - d9b499f fix: recover from panic during shell completion with unknown flags (gopasspw#3388) - d9b731c openbsd: allow unix sockets in pledge (gopasspw#3381) - bcb749a Fix unit and integration test failures - 088aec2 gopass doctor does not fail on Linux - 1f51343 fix: fix lint issues and update tests for removed show -f/--force alias - bd288b3 Add Changelog entries - 7789405 Clean up - 73c7ae2 Document pending security work - 4891365 fix: add thread safety to SSH identity cache (M-3) - c8b8145 security: validate editor binary exists before invocation (H-3) - 217901f security: bound symlink walk to store root (H-2) - 59ce53d security: restrict template engine secret access and fix error leakage (H-1) - f59f670 security: document and warn on env command secret exposure (C-2) - 85a4334 security: fix path traversal in fs storage layer (C-1) - 7d52742 fix(todos): resolve all stale TODOs from S-5 - ee168e7 fix(queue): fix Idle() TOCTOU race and Add() post-Close() panic - 9a6a5c9 Add a plan to split the storage interface - 8b9e989 refactor(ctxutil): replace context-key config system with typed structs (A-2) - d4f0e92 Mark A-1 as fixed - a16d7f5 refactor(action): split Action god object into focused handler types (A-1) - d53a1c2 feat(env): add --stdin, --file, and --exec modes to gopass env - e8f80d7 feat: add configurable show.hidden-keys for safecontent redaction - dc14463 feat: machine-readable JSON output (I-3) - 23dae78 feat: structured exit codes (I-2) - 55d99e2 Update fixed tasks - 6337ede docs: fully document wizard template format (I-7) - 49b6658 feat: add gopass doctor diagnostic command (I-4) - 4211ede Update code quality todos - 49dddf7 fix: address A-5, S-1, S-2, S-3, S-4, S-6 and I-1 from code quality audit - 1766037 fix: address CLI/UX issues from code quality audit - fd43b75 docs: fix all documentation vs. implementation mismatches from code quality report - 9f76dc4 fix: address all confirmed bugs from code quality report - fbe5983 Add code quality reports - fd816c8 Maintenance update (gopasspw#3380) - 95f31e7 fix(config): restore sub-store fallback for core.exportkeys (gopasspw#3379) - cd8bd69 chore(deps): bump actions/setup-go from 6.3.0 to 6.4.0 (gopasspw#3367) - 47d403d chore(deps): bump sigstore/cosign-installer from 4.0.0 to 4.1.1 (gopasspw#3373) - 9650d43 chore(deps): bump msys2/setup-msys2 from 2.29.0 to 2.31.0 (gopasspw#3370) - 9a8e33a chore(deps): bump step-security/harden-runner from 2.15.0 to 2.16.1 (gopasspw#3371) - ee7a6e4 chore(deps): switch from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 (gopasspw#3362) - 5440c58 fix: REPL tab-completion for entries with spaces (gopasspw#3360) - 6fe6aac chore(deps): bump crazy-max/ghaction-import-gpg from 6.3.0 to 7.0.0 (gopasspw#3368) - 18f5031 chore(deps): bump github/codeql-action from 4.32.4 to 4.35.1 (gopasspw#3369) - a870127 chore(deps): bump anchore/scan-action from 7.3.2 to 7.4.0 (gopasspw#3372) - c95c577 chore(deps): bump actions/cache from 5.0.3 to 5.0.4 (gopasspw#3374) - a57169f chore(deps): bump docker/metadata-action from 5.10.0 to 6.0.0 (gopasspw#3375) - d3328c6 chore(deps): bump anchore/sbom-action from 0.23.0 to 0.24.0 (gopasspw#3376) - f6985fa Re-encrypt when copying secrets (gopasspw#3361) - 3c882bc chore(deps): bump docker/build-push-action from 6.19.2 to 7.0.0 (gopasspw#3377) - 3eb217d chore(deps): bump docker/login-action from 3.7.0 to 4.0.0 (gopasspw#3378) - 15d6e72 Update faq.md (gopasspw#3365) - 72c44f6 Add support for post-quantum age keys (gopasspw#3358) - 1890055 docs: add gopass-secret-service to integrations list (gopasspw#3356) - 0529c84 fix: Support strict character class enforcement in create templates (gopasspw#3352) - bd42a02 Run `go fix ./...` to modernize the codebase (gopasspw#3351) - e5ac74e chore(deps): bump goreleaser/goreleaser-action from 6.4.0 to 7.0.0 (gopasspw#3343) - 7084900 chore(deps): bump docker/build-push-action from 6.18.0 to 6.19.2 (gopasspw#3342) - fca9dcf chore(deps): bump step-security/harden-runner from 2.13.2 to 2.15.0 (gopasspw#3344) - 3fa8dc4 chore(deps): bump anchore/scan-action from 7.2.1 to 7.3.2 (gopasspw#3346) - 3d60d1c chore(deps): bump github/codeql-action from 4.31.6 to 4.32.4 (gopasspw#3345) - 574c382 chore(deps): bump actions/upload-artifact from 5.0.0 to 7.0.0 (gopasspw#3347) - d0e2db4 chore(deps): bump anchore/sbom-action from 0.20.10 to 0.23.0 (gopasspw#3348) - 723931d chore(deps): bump actions/setup-go from 6.2.0 to 6.3.0 (gopasspw#3349) - 8839181 Fix broken MDN link (developer.mozilla.org/en-US/Add-ons → /en-US/docs/Mozilla/Add-ons) (gopasspw#3354) - cf4f699 chore(deps): bump github.com/cloudflare/circl from 1.6.1 to 1.6.3 (gopasspw#3341) - 71b1724 [BUGFIX] Update fish completion to remove warning (gopasspw#3339) - cc5eaf9 fix: Correctly honor show.safecontent overrides in substores (gopasspw#3337) - aea4987 Fix autocompletion issues (gopasspw#3336) - 43ada6d Use clipboard.WritePassword on MacOS (gopasspw#3335) - 96b797d [feat] Add --safe flag to set safecontent on demand (gopasspw#3318) - 009a9f2 Do not attempt to use nil secret when converting a store (gopasspw#3334) - 83f3324 chore(deps): bump docker/login-action from 3.6.0 to 3.7.0 (gopasspw#3330) - f4c766d chore(deps): bump actions/setup-go from 6.1.0 to 6.2.0 (gopasspw#3329) - 83a31c6 chore(deps): bump actions/cache from 4.3.0 to 5.0.3 (gopasspw#3324) - 40d35c9 chore(deps): bump actions/checkout from 6.0.0 to 6.0.2 (gopasspw#3326) - a7df3fa fix(CI): moving to go 1.25 (gopasspw#3322) - be80cf2 fix(docs): removing reference to invalid 'gopass binary' command, and adding docs for 'fsmove' and 'fscopy' (gopasspw#3321) - 736bf10 docs(otp): document the various supported ways of adding OTP (gopasspw#3323)
This makes actual functionality follow status quo documentation. Also does not access ~/.ssh unless user ir explicit about that.
If age.ssh-key-path is set, it is loaded in addition to age.sshkeys, if that is enabled, or instead of those, if not.
Fixes #3522