Repository navigation
feat(create): support passwordless / SSO login profiles - #3493
Merged
dominikschulz merged 1 commit intoSep 9, 2026
Merged
Conversation
1995parham
force-pushed
the
feat/passwordless-sso-profiles
branch
from
July 16, 2026 17:57
e0d4f7b to
bb4fb91
Compare
dominikschulz
self-requested a review
August 10, 2026 21:12
Add a way to model accounts that have no stored password because login happens through an external provider (e.g. Google, Apple, SSO). - New default "SSO / passwordless login" wizard template that records the provider in a `login-method` field instead of prompting for a password. - New `choice` attribute type so templates can offer a fixed list of options (used for the login-method provider picker). - Optional passwords: a `password` attribute marked `optional: true` lets the user skip password entry, so a single template can serve both password and passwordless accounts. The secret model already tolerates an empty password, so no changes to the Secret interface or storage format are required. Signed-off-by: Parham Alvani <parham.alvani@gmail.com>
1995parham
force-pushed
the
feat/passwordless-sso-profiles
branch
from
September 2, 2026 03:01
bb4fb91 to
f18564e
Compare
Member
|
Sorry for the delay here. The idea sounds reasonable, I simply didn't get to look at the code, yet. |
dominikschulz
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a way to model accounts that have no stored password because login happens through an external provider (e.g. Google, Apple, SSO / social login).
The secret model already tolerates an empty password (first line), so this needs no changes to the
Secretinterface or the storage format — everything lives in thegopass createwizard.Changes
internal/create/templates.go). It shows up ingopass createand records the provider in alogin-methodfield instead of prompting for a password:choiceattribute type (internal/create/wizard.go) so a template can offer a fixed list of options. The SSO template uses it for the provider picker (google,apple,github,microsoft,sso,magic-link). Backed by the existingcui.GetSelectionhelper.passwordattribute markedoptional: trueasks "Does this account have a password?" and skips password entry entirely when declined (instead of storing a blank one). This lets a single template serve both password and passwordless accounts. Existing templates leave the flag unset, so their behaviour is unchanged.choicetype, and theoptionalflag.Notes
websitesprefix (2-websites.yml), so there is no collision with the0-websites.ymlWebsite login template. Happy to move it under a dedicated prefix (e.g.sso/) if preferred.gopass showalready handles empty-password secrets gracefully (it only errors when both password and body are empty, and guards clipboard/QR on a non-empty password), so passwordless entries display and behave correctly.