Skip to content

fix(config): use the config propery generate.strict as default value … - #3303

Merged
dominikschulz merged 1 commit into
gopasspw:masterfrom
mragab:config-generate-strict
Dec 13, 2025
Merged

dominikschulz merged 1 commit into
gopasspw:masterfrom
mragab:config-generate-strict

Conversation

@mragab

@mragab mragab commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Use the config property "generate.strict" as default value for "Strict rules"

The config property "generate.strict" is mentioned in docs/config.md but was not used in the code here, unlike "generate.symbols" where the configuration is loaded and used as the default value, as expected.

The code change follows what is already there for reading and using generate.symbols config property.

Copilot AI review requested due to automatic review settings December 10, 2025 14:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the generate.strict configuration property was documented but not actually used in the code. The change ensures that the user's configured preference for strict password generation rules is now properly respected as the default value in the password generation wizard, bringing it into alignment with how generate.symbols is already handled.

  • Applied the same config-reading pattern used for generate.symbols to generate.strict

…for Strict rules

Signed-off-by: Mohamed Ragab <moragab@gmail.com>
@mragab
mragab force-pushed the config-generate-strict branch from ab6ca0f to 30df3dc Compare December 10, 2025 15:41
@dominikschulz
dominikschulz merged commit 83c7760 into gopasspw:master Dec 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址