Repository navigation
fix(config): use the config propery generate.strict as default value … - #3303
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the generate.strict configuration property was documented but not actually used in the code. The change ensures that the user's configured preference for strict password generation rules is now properly respected as the default value in the password generation wizard, bringing it into alignment with how generate.symbols is already handled.
- Applied the same config-reading pattern used for
generate.symbolstogenerate.strict
…for Strict rules Signed-off-by: Mohamed Ragab <moragab@gmail.com>
mragab
force-pushed
the
config-generate-strict
branch
from
December 10, 2025 15:41
ab6ca0f to
30df3dc
Compare
dominikschulz
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the config property "generate.strict" as default value for "Strict rules"
The config property "generate.strict" is mentioned in docs/config.md but was not used in the code here, unlike "generate.symbols" where the configuration is loaded and used as the default value, as expected.
The code change follows what is already there for reading and using generate.symbols config property.