Repository navigation
Use present imperative tense for commits on move events - #1222
Merged
Merged
Conversation
Signed-off-by: Lucas Nicodemus <shank@shanked.me>
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 62.61% 62.61%
=======================================
Files 184 184
Lines 10294 10294
=======================================
Hits 6445 6445
Misses 3050 3050
Partials 799 799
Continue to review full report at Codecov.
|
|
Good, this is in alignment with best practices on commit messages. |
dominikschulz
approved these changes
Dec 19, 2019
dominikschulz
left a comment
Member
There was a problem hiding this comment.
Present tense sounds good for commit messages.
Thank you. Feel free to change other occurrences, too.
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Signed-off-by: Lucas Nicodemus <shank@shanked.me>
dominikschulz
pushed a commit
that referenced
this pull request
Aug 10, 2026
I am trying gopass as an enhanced alternative to pass and as a backup vault for my primary password manager. I used pass occasionally for many years and noticed that gopass uses the past tense in some generated commit messages. Even though it is really a nit, I see the usual pass commit messages alongside gopass's slightly off past-tense ones in the same vault as I adapt to using gopass. This aligns those messages with the imperative-mood convention accepted in #1222. Most changes were edited and reviewed with AI assistance. Signed-off-by: Ivan Kovnatsky <75213+ivankovnatsky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know what you're thinking: "you sent a PR for this? come now!"
This changes the commit messages for moving files to be present imperative tense instead of past tense. Related things that bother me are "Exported public keys" and "Added recipient" which disagree with "Save secret" and "Remove blah from store" in terms of tense. If we're good with using present imperative tense everywhere, I will gladly send patches that change the convention everywhere.