Skip to content

Use present imperative tense for commits on move events - #1222

Merged
dominikschulz merged 1 commit into
gopasspw:masterfrom
hakusaro:pic-move
Dec 19, 2019
Merged

dominikschulz merged 1 commit into
gopasspw:masterfrom
hakusaro:pic-move

Conversation

@hakusaro

@hakusaro hakusaro commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

I know what you're thinking: "you sent a PR for this? come now!"

This changes the commit messages for moving files to be present imperative tense instead of past tense. Related things that bother me are "Exported public keys" and "Added recipient" which disagree with "Save secret" and "Remove blah from store" in terms of tense. If we're good with using present imperative tense everywhere, I will gladly send patches that change the convention everywhere.

Signed-off-by: Lucas Nicodemus <shank@shanked.me>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1222 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   62.61%   62.61%           
=======================================
  Files         184      184           
  Lines       10294    10294           
=======================================
  Hits         6445     6445           
  Misses       3050     3050           
  Partials      799      799
Impacted Files Coverage Δ
pkg/store/root/move.go 35.11% <0%> (ø) ⬆️
pkg/store/sub/move.go 55.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaff428...eaa2a11. Read the comment docs.

@vngzs

vngzs commented Dec 2, 2019

Copy link
Copy Markdown

Good, this is in alignment with best practices on commit messages.

@dominikschulz dominikschulz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Present tense sounds good for commit messages.

Thank you. Feel free to change other occurrences, too.

@dominikschulz
dominikschulz merged commit a2d196e into gopasspw:master Dec 19, 2019
@hakusaro
hakusaro deleted the pic-move branch December 19, 2019 17:51
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Signed-off-by: Lucas Nicodemus <shank@shanked.me>
dominikschulz pushed a commit that referenced this pull request Aug 10, 2026
I am trying gopass as an enhanced alternative to pass and as a backup vault
for my primary password manager. I used pass occasionally for many years and
noticed that gopass uses the past tense in some generated commit messages.

Even though it is really a nit, I see the usual pass commit messages alongside
gopass's slightly off past-tense ones in the same vault as I adapt to using
gopass.

This aligns those messages with the imperative-mood convention accepted in
#1222.

Most changes were edited and reviewed with AI assistance.

Signed-off-by: Ivan Kovnatsky <75213+ivankovnatsky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址