You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gopass edit fails: -c option, 1: The - command is unknown #2424
🚥 Syncing with all remotes ...
[<root>]
gitfs pull and push ... Skipped (no remote)
✅ All done
✅ Found exact match in "websites/foo.com/foo"
Secret does not exist "foo". Found possible match in "websites/foo.com/foo". Edit existing entry? [Y/n/q]: y
vi: illegal option -- i
usage: ex [-eFRrSsv] [-c command] [-t tag] [-w size] [file ...]
usage: vi [-eFlRrSv] [-c command] [-t tag] [-w size] [file ...]
Error: failed to invoke editor: failed to run vi with /tmp/gopass-edit3796617766/secret file: exit status 1
Yes, I think you are right. We must at least check if vi is actually a vim. And then this test might fail depending on where it's run. Oh what a fun ...
Activity
dominikschulz commentedon Nov 22, 2022
sigh Thanks for the feedback. I'm starting to think that we should maybe just require (a real) vim ...
dominikschulz commentedon Nov 22, 2022
But for the time being I should start to use/test gopass with a non-vim
vi.ehaupt commentedon Nov 22, 2022
I understand the sentiment but that would blow up the dependency chain quite a lot.
It's safe to assume that
$EDITOR FILEwill suffice.If you like to test the FreeBSD port you can quickly spin up a vagrant box. This one should suffice.
Thank you for the quick response 😺
Drop all options when we are not sure if EDITOR is vim
Drop all options when we are not sure if EDITOR is vim
Drop all options when we are not sure if EDITOR is vim (#2427)
nunotexbsd commentedon Nov 25, 2022
1.14.11
EDITOR=vi
gopass edit foonunotexbsd commentedon Dec 2, 2022
Shouldn't vi options set to {} like nvi?
IMHO nvi and vi options should be set to {}
Tested with EDITOR=nvi (defaults FreeBSD EDITOR=vi)
dominikschulz commentedon Dec 2, 2022
Yes, I think you are right. We must at least check if vi is actually a vim. And then this test might fail depending on where it's run. Oh what a fun ...
Let me reopen this, again.
Fix vim detection. Again.
dominikschulz commentedon Dec 6, 2022
I was able to reproduce the issue. The test isn't very elegant, but the workflow should now at least work.
Fix vim detection. Again. (#2456)
nunotexbsd commentedon Dec 8, 2022
Works fine with vi/nvi.
Thanks!