Skip to content
This repository was archived by the owner on Oct 20, 2026. It is now read-only.
This repository was archived by the owner on Oct 20, 2026. It is now read-only.

Stale reads documentation and samples are outdated #2129

Description

@kosanin

Version v3.0.0 introduced a breaking change where timestamp bounds now expect milliseconds precision but in the sample code there is a comment that staleness is specified in seconds. Same issue is also present in the documentation for the client library.

Sample should have following options to perform 15 seconds stale read:

const options = {
    // Guarantees that all writes committed more than 15 seconds ago are visible
    exactStaleness: 15000,
};

Activity

  1. added
    api: spannerIssues related to the googleapis/nodejs-spanner API.
    samplesIssues that are directly related to samples.
    on Sep 27, 2024
  2. alkatrivedi commented on Oct 3, 2024

    @alkatrivedi
    Contributor

    Hi @kosanin, thanks for pointing it out. I have raised a PR for this.

  3. added a commit that references this issue on Oct 14, 2024
    f01516e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: spannerIssues related to the googleapis/nodejs-spanner API.samplesIssues that are directly related to samples.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址