Skip to content
This repository was archived by the owner on Oct 20, 2026. It is now read-only.
This repository was archived by the owner on Oct 20, 2026. It is now read-only.

Unable to rollback transaction with no activity or with only queued mutations #2103

Description

@BobDickinson

Environment details

  • OS: MacOS Sonomia 14.6.1
  • Node.js version: 20.9.0
  • npm version: 10.1.0
  • @google-cloud/spanner version: 7.14.0

Steps to reproduce

  1. Create a transaction - I use getTransaction()
  2. Attempt transaction.rollback()

Or alternatively, execute any number of insert, upsert, delete, etc operations on the transaction and then attempt rollback().

When attempting to rollback() a transaction that hasn't had any activity, or that has only had queued mutation activity, calling rollback() on that transaction throws an error: 'Transaction ID is unknown, nothing to rollback.'

From here:

'Transaction ID is unknown, nothing to rollback.'

Expected behavior

Any transaction in a state where it can be successfully committed should also be able to be rolled back without error.

The notion of the transaction id being set when the transaction has actually begun with Spanner (and there is something to roll back), and the idea of queued mutations, are internal to the library (not explained anywhere in the docs that I could find), so requiring the user to understand that they cannot call rollback() under these certain (only known to the library authors) conditions does not seem correct.

The workaround is pretty straightforward, but required me to spend a couple of hours with the library source code to ensure that it was correct (essentially, if id is not set, call end() instead of rollback() to abort the transaction).

The correct behavior would be for the transaction.rollback() to succeed (not throw an error) in this case (no id set, and potentially outstanding queue mutations) - it's a logically valid usage and the result is a noop, maybe with an internal call to end(), so why you would throw an error in that case is beyond me, especially given that the semantics the SDK user would need to understand to avoid the error are not documented AFAICT.

Just trying to save anyone else the 2 hours I spend on this issue. Thanks.

Activity

  1. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Sep 9, 2024
  2. added a commit that references this issue on Feb 7, 2025
    a6919b1
  3. added 3 commits that reference this issue on Feb 7, 2025
    9627146
    9564c2d
    9bf3a2b
  4. added a commit that references this issue on Feb 17, 2025
    2cc44cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: spannerIssues related to the googleapis/nodejs-spanner API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址