Skip to content
This repository was archived by the owner on Sep 25, 2026. It is now read-only.
This repository was archived by the owner on Sep 25, 2026. It is now read-only.

allow specifying the content length for resumable uploads #2511

Description

@benjaminp

Is your feature request related to a problem? Please describe.
The resumable upload API allows specifying a final length of the object if known in a HTTP header. There is no way to pass this value into the Java GCS API for resumable uploads, though.

Describe the solution you'd like
A Storage.writer method overload that takes the final content length.

Activity

  1. BenWhitehead commented on Apr 24, 2024

    @BenWhitehead
    Collaborator

    In general we recommend folks use checksums for validation of all intended bytes reaching gcs rather than relying on the number of bytes. Using a checksum like crc32c will ensure the bytes are received in the correct sequence and match with what GCS receives.

    For an example of how the crc32c precondition is provided to an upload, you can take a look at one of our integration tests that verify correct checksum plumbing and handling

    storage.writer(
    blobInfo, BlobWriteOption.doesNotExist(), BlobWriteOption.crc32cMatch())) {

    To compute a crc32c checksum you can use Guava's crc32c HashFunction https://guava.dev/releases/33.1.0-jre/api/docs/com/google/common/hash/Hashing.html#crc32c()

  2. benjaminp commented on Apr 24, 2024

    @benjaminp
    ContributorAuthor

    I agree that a checksum of the content is preferable when available. However, sometimes you are proxying a file from a client that gives you the size upfront but not a checksum in which case GCS verifying the size is better than nothing.

  3. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    and removed
    type: questionRequest for information or clarification. Not an issue.
    on Aug 5, 2024
  4. added a commit that references this issue on Aug 6, 2024
    b85b4fc
  5. added a commit that references this issue on Aug 23, 2024
    2765ef8
  6. added a commit that references this issue on Aug 23, 2024
    3405611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: storageIssues related to the googleapis/java-storage API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址