Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Cloud Build configuration (ci/cloudbuild/system-test.yaml) to run system tests in shards, featuring an inline Python script to filter packages and a pytest shim to handle Google Application Credentials. The review feedback highlights two important issues: first, a potential mismatch in package path filtering due to trailing slashes that could silently skip tests, and second, a risk of unexpected module shadowing caused by a trailing colon in PYTHONPATH when it is initially empty.
Contributor
Author
|
/gcbrun |
parthea
force-pushed
the
add-gcb-google-cloud-bigquery-storage
branch
from
November 17, 2026 17:44
329d1ff to
db46153
Compare
parthea
force-pushed
the
add-gcb-google-cloud-bigquery-storage
branch
from
November 17, 2026 17:50
db46153 to
3f87a9a
Compare
parthea
force-pushed
the
add-gcb-google-cloud-bigquery-storage
branch
from
November 17, 2026 19:08
3f87a9a to
41bfa40
Compare
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
parthea
force-pushed
the
add-gcb-google-cloud-bigquery-storage
branch
from
November 19, 2026 17:02
444f0b6 to
06aa46e
Compare
Contributor
Author
|
needs cl/1024879907 |
Contributor
Author
|
/gcbrun |
This reverts commit 06aa46e.
Contributor
Author
|
/gcbrun |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/578989906