Skip to content

ci: configure systems tests using cloud build - #18976

Draft
parthea wants to merge 22 commits into
mainfrom
add-gcb-google-cloud-bigquery-storage
Draft

parthea wants to merge 22 commits into
mainfrom
add-gcb-google-cloud-bigquery-storage

Conversation

@parthea

@parthea parthea commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Towards b/578989906

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Cloud Build configuration (ci/cloudbuild/system-test.yaml) to run system tests in shards, featuring an inline Python script to filter packages and a pytest shim to handle Google Application Credentials. The review feedback highlights two important issues: first, a potential mismatch in package path filtering due to trailing slashes that could silently skip tests, and second, a risk of unexpected module shadowing caused by a trailing colon in PYTHONPATH when it is initially empty.

Comment thread ci/cloudbuild/system-test.yaml Resolved
Comment thread ci/cloudbuild/system-test.yaml Resolved
@parthea parthea closed this Nov 4, 2026
@parthea parthea reopened this Nov 4, 2026
@parthea parthea closed this Nov 4, 2026
@parthea parthea reopened this Nov 4, 2026
@parthea parthea closed this Nov 5, 2026
@parthea parthea reopened this Nov 5, 2026
@parthea parthea closed this Nov 5, 2026
@parthea parthea reopened this Nov 5, 2026
@parthea parthea closed this Nov 5, 2026
@parthea parthea reopened this Nov 5, 2026
@parthea parthea changed the title ci: configure systems tests using cloud build for google-cloud-bigquery-storage ci: configure systems tests using cloud build Nov 5, 2026
@parthea
parthea changed the base branch from main to remove-smoke-tests November 17, 2026 17:41
@parthea
parthea added this pull request to stack #19112 November 17, 2026 17:41
@parthea

parthea commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from 329d1ff to db46153 Compare November 17, 2026 17:44
@parthea parthea closed this Nov 17, 2026
@parthea parthea reopened this Nov 17, 2026
Base automatically changed from remove-smoke-tests to main November 17, 2026 17:49
@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from db46153 to 3f87a9a Compare November 17, 2026 17:50
@parthea parthea closed this Nov 17, 2026
@parthea parthea reopened this Nov 17, 2026
@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from 3f87a9a to 41bfa40 Compare November 17, 2026 19:08
@parthea parthea closed this Nov 18, 2026
@parthea parthea reopened this Nov 18, 2026
@parthea

parthea commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment
@parthea

parthea commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

@parthea parthea self-assigned this Nov 18, 2026
@parthea

parthea commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

@parthea

parthea commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment
@parthea

parthea commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from 444f0b6 to 06aa46e Compare November 19, 2026 17:02
@parthea

parthea commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

needs cl/1024879907

@parthea

parthea commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

This reverts commit 06aa46e.
@parthea

parthea commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址