Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-cloud-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.95.0
Choose a base ref
...
head repository: googleapis/google-cloud-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.96.0
Choose a head ref
  • 10 commits
  • 4,401 files changed
  • 9 contributors

Commits on Nov 4, 2026

  1. fix(bigquery): handle empty queryParameters list in ConnectionImpl (#…

    …14917)
    
    Check `!queryParameters.isEmpty()` before accessing
    `queryParameters.get(0)` in `ConnectionImpl.createQueryRequest` and
    `ConnectionImpl.createQueryJob`.
    
    b/495486731
    
    ---------
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    jinseopkim0 and gemini-code-assist[bot] authored Nov 4, 2026
    Configuration menu
    Copy the full SHA
    cfea223 View commit details
    Browse the repository at this point in the history
  2. test(spanner): reset tracing framework in tests to prevent state leak…

    …age (#14906)
    
    Several tests configure OpenTelemetry tracing globally during execution.
    Without explicit teardown, this configuration persists across tests in
    the same test run and causes subsequent tests that expect the default
    tracing behavior to fail or behave inconsistently.
    
    This change ensures that all tests enabling a custom tracing framework
    cleanly restore the default tracing state when they finish. Teardown
    routines are guarded so that unrelated errors during cleanup cannot
    bypass the reset, and tests defensively clear any preexisting state
    before enabling custom tracing.
    olavloite authored Nov 4, 2026
    Configuration menu
    Copy the full SHA
    0c20c1b View commit details
    Browse the repository at this point in the history
  3. fix(bigquery-jdbc): preserve civil digits for DATETIME/DATE (#14910)

    b/577457022
    
    ### Summary
    Prevents JVM default timezone DST gaps and historical calendar shifts
    from corrupting timezone-less civil temporal types (`DATETIME`, `DATE`,
    `TIME`) when accessed as `java.sql.Date`, `java.sql.Time`, or formatted
    inside `ARRAY` and `STRUCT`.
    
    ### Root Cause
    1. **`Date` / `Time` extraction from `DATETIME`**:
    `BigQueryBaseResultSet` (`getDate`, `getTime`, `getObject(int, Class)`)
    and `BigQueryTypeRegistry` (`createDatetimeDescriptor`) boxed `DATETIME`
    values into an intermediate `java.sql.Timestamp` in the JVM default
    timezone before extracting `Date` or `Time`. When a `DATETIME` value
    fell inside a local DST spring-forward gap (e.g., `2025-03-09 02:30:00`
    in `America/New_York`), the intermediate `Timestamp` shifted the
    wall-clock hour forward by +1 hour (`03:30:00`).
    2. **`ARRAY` / `STRUCT` string formatting**:
    `BigQueryBaseArray.toString()` and
    `BigQueryBaseStruct.appendJsonValue()` called `.toString()` on boxed
    `java.sql.Timestamp` / `java.sql.Date` elements, corrupting
    `ARRAY<DATETIME>` / `STRUCT<DATETIME>` values in DST gaps and
    `ARRAY<DATE>` / `STRUCT<DATE>` values prior to the 1582 Julian–Gregorian
    cutover.
    
    ### Changes
    - **`BigQueryTemporalUtility`**: Added `isCivilTemporalType` and
    `formatCivilTemporalElement` to centralize civil type checks and format
    raw `DATE`, `TIME`, and `DATETIME` elements directly from their
    unshifted civil representation.
    - **`BigQueryTypeRegistry`**: Unified `createDatetimeDescriptor` to
    parse `DATETIME` into `LocalDateTime` once and project directly to
    `Date`, `Time`, `LocalDate`, `LocalTime`, `LocalDateTime`, `String`, or
    instant views without intermediate `Timestamp` boxing.
    - **`BigQueryBaseResultSet`**: Updated `getObject`, `getDate`,
    `getTime`, and `getTimestamp` to pass raw unboxed values for civil
    temporal types (`DATE`, `TIME`, `DATETIME`) to `BigQueryTypeRegistry`.
    - **`BigQueryBaseArray` & `BigQueryBaseStruct`**: Updated string/JSON
    formatting to format civil temporal elements directly from raw values
    via `BigQueryTemporalUtility.formatCivilTemporalElement`.
    keshavdandeva authored Nov 4, 2026
    Configuration menu
    Copy the full SHA
    53bbde0 View commit details
    Browse the repository at this point in the history
  4. chore: update googleapis commitish to 856bc83 (#14923)

    Updated googleapis commitish in librarian.yaml to
    googleapis/googleapis@856bc83
    
    💡 **Note:** If this PR is still open when the daily update workflow runs
    next, it will be closed and replaced with a new PR containing the latest
    updates.
    cloud-java-bot authored Nov 4, 2026
    Configuration menu
    Copy the full SHA
    efb3497 View commit details
    Browse the repository at this point in the history
  5. feat(google/cloud/saasplatform/saasservicemgmt/v1): add saasservicemg…

    …mt (#14925)
    
    Onboard google/cloud/saasplatform/saasservicemgmt/v1 API
    (saasservicemgmt).
    
    Internal tracking bug http://b/581338653
    
    PiperOrigin-RevId: 1012966905
    
    ## Manual changes
    
    For Java, `librarian add google/cloud/saasplatform/saasservicemgmt/v1`
    derives the library name `saasplatform-saasservicemgmt`
    (`java.DefaultLibraryName`). That name doesn't match the existing
    `saasservicemgmt` library, which already contains
    `google/cloud/saasplatform/saasservicemgmt/v1beta1`, so `add` would
    create a duplicate library and artifact
    (`google-cloud-saasplatform-saasservicemgmt`). `--name` is Ruby-only.
    Instead, I reverted the `add` output and added v1 to the existing
    library by hand, making the same changes `add` makes for an existing
    library:
    
    - `librarian.yaml`: appended `- path:
    google/cloud/saasplatform/saasservicemgmt/v1` to the `saasservicemgmt`
    library's `apis:`, with `java.additional_protos:
    [google/cloud/location/locations.proto]`. This is the mixin that `add`
    resolved from the v1 service yaml.
    - `versions.txt`: added
    `proto-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0` and
    `grpc-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0`.
    
    `librarian tidy` left both edits unchanged; vs main, the
    `librarian.yaml` diff is only the added v1 API entry. Everything else in
    this PR is output from `librarian generate`.
    
    > [!NOTE]
    > Review item: `librarian generate` dropped `"rpc_documentation":
    "https://cloud.google.com/saas-runtime/docs/apis"` from
    `java-saasservicemgmt/.repo-metadata.json`. It is generator output, not
    a manual edit.
    
    ## Debug Info
    ### System Details
    - JDK version: 17.0.20.1
    (`JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64`, the runtime Maven
    reports and the one it compiled with, via in-process
    `jdk.compiler@17.0.20.1`). This JDK 17 install ships no `javac` binary,
    so `javac -version` on PATH reports `javac 26.0.2.1`.
    - Maven version: Apache Maven 3.9.12
    - OS: Linux 7.1.6-1rodete1-amd64 x86_64
    - Librarian version: v0.51.0
    
    ### Commands Executed
    ```bash
    export JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
    export PATH="$JAVA_HOME/bin:$PATH"
    export MAVEN_SKIP_RC=true
    MAVEN_SKIP_RC=true go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 install
    export PATH="$PATH:$HOME/.cache/librarian/bin/java_tools/bin"
    go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 add google/cloud/saasplatform/saasservicemgmt/v1
    go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 config get libraries google/cloud/saasplatform/saasservicemgmt/v1   # -> saasplatform-saasservicemgmt (see Manual changes)
    git checkout -- librarian.yaml versions.txt
    # manual edit: append v1 to the saasservicemgmt library's apis in librarian.yaml (see Manual changes)
    printf 'proto-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0\ngrpc-google-cloud-saasservicemgmt-v1:0.31.0:0.31.0\n' >> versions.txt
    go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 tidy
    go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 generate saasservicemgmt
    ARTIFACT_ID=$(xmllint --xpath "/*[local-name()='project']/*[local-name()='artifactId']/text()" java-saasservicemgmt/pom.xml 2>/dev/null)   # -> google-cloud-saasservicemgmt-parent
    mvn -B -ntp compile -pl ":${ARTIFACT_ID:-google-cloud-saasservicemgmt}" -am   # BUILD SUCCESS (parent pom only)
    mvn -B -ntp compile -pl :google-cloud-saasservicemgmt -am   # BUILD SUCCESS (proto/grpc v1 + v1beta1 + client)
    go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 tidy
    git add .
    git commit -m "feat(google/cloud/saasplatform/saasservicemgmt/v1): add saasservicemgmt"
    ```
    
    🤖 _Opened by an AI agent on behalf of zhumin._
    zhumin8 authored Nov 4, 2026
    Configuration menu
    Copy the full SHA
    8535344 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2026

  1. fix(bigtable): allow non-default service accounts for session DirectA…

    …ccess (#14926)
    
    ### Problem
    
    Workloads running on Compute Engine or GKE with a non-default service
    account (for example, GKE Workload Identity Federation or explicit
    service account credentials) cannot establish DirectPath
    (`DirectAccess`) connections on the session-based protocol path
    (`ShimImpl` and `GaxDirectAccessChannelProvider`), even when classic
    unary RPCs on the same client successfully use DirectPath. Instead,
    session channels fall back to CloudPath (`GaxBasicChannelProvider`) and
    report `direct_access/compatible=0`.
    
    ### Root Cause
    
    `ShimImpl.create` and both factory methods in
    `GaxDirectAccessChannelProvider` (`create` and `createWithFallback`)
    called `.setAttemptDirectPath(true).setAttemptDirectPathXds()` without
    setting `.setAllowNonDefaultServiceAccount(true)`.
    
    Without `setAllowNonDefaultServiceAccount(true)`,
    `InstantiatingGrpcChannelProvider.isCredentialDirectPathCompatible()`
    only accepts `ComputeEngineCredentials` and returns `false` for other
    credential types. Consequently,
    `directAccessProvider.canUseDirectPath()` returns `false` in
    `GaxDirectAccessChannelProvider`, causing
    `GaxDirectAccessChannelProvider.createWithFallback` to immediately
    return a CloudPath `GaxBasicChannelProvider`.
    
    ### Fix
    
    - Enable `.setAllowNonDefaultServiceAccount(true)` on the DirectAccess
    `InstantiatingGrpcChannelProvider` builders in `ShimImpl.create`,
    `GaxDirectAccessChannelProvider.create`, and
    `GaxDirectAccessChannelProvider.createWithFallback`.
    
    ### Testing
    
    - Added `GaxDirectAccessChannelProviderTest` verifying that `create` and
    `createWithFallback` return `GaxDirectAccessChannelProvider` on a GCE
    Linux environment when configured with non-`ComputeEngineCredentials`
    credentials.
    sushanb authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    9f4a76a View commit details
    Browse the repository at this point in the history
  2. refactor(spanner): decouple read-only transactions from async result …

    …sets (#14902)
    
    Decouple multi-use read-only transactions from internal async result set
    implementation details by introducing a dedicated lifecycle callback.
    
    Key improvements in this change:
    - Replaces the anonymous subclass in read-only transactions with a clean
    callback that signals when an asynchronous query either begins execution
    or is closed without starting.
    - Lazily resolves the underlying query stream so that closing an async
    query before it begins execution no longer starts the query or opens an
    RPC stream, preventing unnecessary network calls and session
    allocations.
    - Permits safe inspection of query statistics and metadata after a
    result set has been closed.
    - Adds comprehensive unit tests for the decoupled lifecycle, post-close
    inspections, and closed-state error handling.
    olavloite authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    62bdb10 View commit details
    Browse the repository at this point in the history
  3. feat(gax): wire-level changes for resuming uploads (#14870)

    - parse chunk granularity from query responses so that user-provided
    chunk size on resume can be aligned to the server's granularity when
    present
    - consolidate header name constants and `parseChunkGranularity` (now
    used in both start and query) into a new `ResumableUploadHeaders` class
    whowes authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    956ac4d View commit details
    Browse the repository at this point in the history
  4. chore(main): release 1.96.0-SNAPSHOT (#14931)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    <details><summary>1.96.0-SNAPSHOT</summary>
    
    ### Updating meta-information for bleeding-edge SNAPSHOT release.
    </details>
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    
    ---------
    
    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    4d48646 View commit details
    Browse the repository at this point in the history
  5. chore(main): release 1.96.0 (#14934)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    <details><summary>1.96.0</summary>
    
    ##
    [1.96.0](v1.95.0...v1.96.0)
    (2026-11-05)
    
    
    ### Features
    
    * **gax:** wire-level changes for resuming uploads
    ([#14870](#14870))
    ([956ac4d](956ac4d))
    
    
    ### Bug Fixes
    
    * **bigquery-jdbc:** preserve civil digits for DATETIME/DATE
    ([#14910](#14910))
    ([53bbde0](53bbde0))
    * **bigquery:** handle empty queryParameters list in ConnectionImpl
    ([#14917](#14917))
    ([cfea223](cfea223))
    * **bigtable:** allow non-default service accounts for session
    DirectAccess
    ([#14926](#14926))
    ([9f4a76a](9f4a76a))
    </details>
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    
    ---------
    
    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    524d6c9 View commit details
    Browse the repository at this point in the history
Loading
⌂ 换网址