Skip to content

fix: propagate transaction through aggregation pipeline - #20772

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
shollyman:fix-fs-tx
Oct 29, 2026
Merged

gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
shollyman:fix-fs-tx

Conversation

@shollyman

Copy link
Copy Markdown
Contributor

Addresses an issue where transactions in AggregationQuery.Pipeline() may not be properly propagated. This change ensures the transaction is retained, and updates the logic in Execute() as well as updating tests.

related: b/577989416

@shollyman
shollyman requested a review from a team as a code owner October 28, 2026 16:26
@shollyman shollyman changed the title fix: propagate transaction through aggregation fix: propagate transaction through aggregation pipeline Oct 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds transaction support to AggregationQuery pipelines in Firestore, ensuring that transaction errors and read-after-write violations are correctly handled during pipeline execution. It also includes comprehensive unit tests to verify these behaviors. The feedback points out a potential panic in the new tests due to an unchecked type assertion on snap.iter.iter, which should be safely handled to prevent test failures from crashing.

Comment thread firestore/query_test.go Resolved
shollyman and others added 3 commits October 28, 2026 09:29
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2026
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 1ecb8a4 into googleapis:main Oct 29, 2026
17 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2026
@release-please release-please Bot mentioned this pull request Oct 29, 2026
sofisl added a commit that referenced this pull request Oct 29, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>ces: 1.6.0</summary>

##
[1.6.0](ces/v1.5.1...ces/v1.6.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>chat: 1.11.0</summary>

##
[1.11.0](chat/v1.10.1...chat/v1.11.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
* Update API sources and regenerate
([#20781](#20781))
([afe21e5](afe21e5))
</details>

<details><summary>designcenter: 0.1.0</summary>

## 0.1.0 (2026-10-29)


### Features

* **google/cloud/designcenter/v1:** Add designcenter
([#20779](#20779))
([232e082](232e082))
</details>

<details><summary>documentai: 1.52.0</summary>

##
[1.52.0](documentai/v1.51.1...documentai/v1.52.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>firestore: 1.29.2</summary>

##
[1.29.2](firestore/v1.29.1...firestore/v1.29.2)
(2026-10-29)


### Bug Fixes

* Propagate transaction through aggregation pipeline
([#20772](#20772))
([1ecb8a4](1ecb8a4))
</details>

<details><summary>geminidataanalytics: 1.8.0</summary>

##
[1.8.0](geminidataanalytics/v1.7.1...geminidataanalytics/v1.8.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>memorystore: 1.7.0</summary>

##
[1.7.0](memorystore/v1.6.1...memorystore/v1.7.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>modelarmor: 1.5.0</summary>

##
[1.5.0](modelarmor/v1.4.1...modelarmor/v1.5.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>oracledatabase: 1.8.0</summary>

##
[1.8.0](oracledatabase/v1.7.1...oracledatabase/v1.8.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>redis: 1.29.0</summary>

##
[1.29.0](redis/v1.28.1...redis/v1.29.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>shopping: 1.19.0</summary>

##
[1.19.0](shopping/v1.18.1...shopping/v1.19.0)
(2026-10-29)


### Features

* **google/shopping/merchant/reviews/v1:** Add shopping
([#20734](#20734))
([4504821](4504821))
* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>sql: 0.5.0</summary>

##
[0.5.0](sql/v0.4.1...sql/v0.5.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

<details><summary>video: 1.36.0</summary>

##
[1.36.0](video/v1.35.1...video/v1.36.0)
(2026-10-29)


### Features

* Update API sources and regenerate
([#20773](#20773))
([f5f113a](f5f113a))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址