Repository navigation
fix: propagate transaction through aggregation pipeline - #20772
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds transaction support to AggregationQuery pipelines in Firestore, ensuring that transaction errors and read-after-write violations are correctly handled during pipeline execution. It also includes comprehensive unit tests to verify these behaviors. The feedback points out a potential panic in the new tests due to an unchecked type assertion on snap.iter.iter, which should be safely handled to prevent test failures from crashing.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
dbolduc
approved these changes
Oct 29, 2026
Merged
sofisl
added a commit
that referenced
this pull request
Oct 29, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>ces: 1.6.0</summary> ## [1.6.0](ces/v1.5.1...ces/v1.6.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>chat: 1.11.0</summary> ## [1.11.0](chat/v1.10.1...chat/v1.11.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) * Update API sources and regenerate ([#20781](#20781)) ([afe21e5](afe21e5)) </details> <details><summary>designcenter: 0.1.0</summary> ## 0.1.0 (2026-10-29) ### Features * **google/cloud/designcenter/v1:** Add designcenter ([#20779](#20779)) ([232e082](232e082)) </details> <details><summary>documentai: 1.52.0</summary> ## [1.52.0](documentai/v1.51.1...documentai/v1.52.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>firestore: 1.29.2</summary> ## [1.29.2](firestore/v1.29.1...firestore/v1.29.2) (2026-10-29) ### Bug Fixes * Propagate transaction through aggregation pipeline ([#20772](#20772)) ([1ecb8a4](1ecb8a4)) </details> <details><summary>geminidataanalytics: 1.8.0</summary> ## [1.8.0](geminidataanalytics/v1.7.1...geminidataanalytics/v1.8.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>memorystore: 1.7.0</summary> ## [1.7.0](memorystore/v1.6.1...memorystore/v1.7.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>modelarmor: 1.5.0</summary> ## [1.5.0](modelarmor/v1.4.1...modelarmor/v1.5.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>oracledatabase: 1.8.0</summary> ## [1.8.0](oracledatabase/v1.7.1...oracledatabase/v1.8.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>redis: 1.29.0</summary> ## [1.29.0](redis/v1.28.1...redis/v1.29.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>shopping: 1.19.0</summary> ## [1.19.0](shopping/v1.18.1...shopping/v1.19.0) (2026-10-29) ### Features * **google/shopping/merchant/reviews/v1:** Add shopping ([#20734](#20734)) ([4504821](4504821)) * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>sql: 0.5.0</summary> ## [0.5.0](sql/v0.4.1...sql/v0.5.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> <details><summary>video: 1.36.0</summary> ## [1.36.0](video/v1.35.1...video/v1.36.0) (2026-10-29) ### Features * Update API sources and regenerate ([#20773](#20773)) ([f5f113a](f5f113a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue where transactions in AggregationQuery.Pipeline() may not be properly propagated. This change ensures the transaction is retained, and updates the logic in Execute() as well as updating tests.
related: b/577989416