Repository navigation
feat(storage/transfermanager): prototype #10045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bee724f
[WIP] feat(storage/transfermanager): prototype
tritone 189f87b
result iterator
tritone a23db2e
mvp, just missing some tests
BrennaEpp bbdd5a6
wip - callbacks and sliced results
BrennaEpp 9fcaca4
finish tests, some cleanup
BrennaEpp 6353ea3
Merge branch 'main' into tm
BrennaEpp ca52f14
revert go.work.sum
BrennaEpp 1d00ad4
vet fixes
BrennaEpp 79d34f4
Merge branch 'main' into tm
BrennaEpp f5a6b33
add grpc tests and errors.join for waitandclose
BrennaEpp 8956b7b
remove bucket creation for short tests
BrennaEpp ed19c7f
parse flags in test main to allow setup to skip in short mode
BrennaEpp 5afae53
suggestions
BrennaEpp 5e42c62
docs + allow waitandclose to be called more than once
BrennaEpp 623fdd3
Merge branch 'main' into tm
BrennaEpp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove bucket creation for short tests
- Loading branch information
commit 8956b7bd214701c804ab9913db6a29e478f7f7de
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -647,6 +647,10 @@ func (tw *testWriter) WriteAt(b []byte, offset int64) (n int, err error) { | |
| } | ||
|
|
||
| func deleteExpiredBuckets(prefix string) error { | ||
| if testing.Short() { | ||
| return nil | ||
| } | ||
|
|
||
| ctx := context.Background() | ||
| client, err := storage.NewClient(ctx) | ||
| if err != nil { | ||
|
|
@@ -713,6 +717,9 @@ type downloadTestBucket struct { | |
| // objects in it. All objects are of the same size but with different contents | ||
| // and can be mapped to their respective crc32c hash in contentHashes. | ||
| func (tb *downloadTestBucket) Create(prefix string) error { | ||
| if testing.Short() { | ||
| return nil | ||
| } | ||
| ctx := context.Background() | ||
|
|
||
| tb.bucket = prefix + uidSpace.New() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should talk about adding some more objects (at least more than the thread count) and of a wider variety of sizes. Can be in a follow up PR though. |
||
|
|
@@ -752,6 +759,9 @@ func (tb *downloadTestBucket) Create(prefix string) error { | |
|
|
||
| // Cleanup deletes the objects and bucket created in Create. | ||
| func (tb *downloadTestBucket) Cleanup() error { | ||
| if testing.Short() { | ||
| return nil | ||
| } | ||
| ctx := context.Background() | ||
|
|
||
| client, err := storage.NewClient(ctx) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.