Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove bucket creation for short tests
  • Loading branch information
BrennaEpp committed May 15, 2024
commit 8956b7bd214701c804ab9913db6a29e478f7f7de
10 changes: 10 additions & 0 deletions storage/transfermanager/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,10 @@ func (tw *testWriter) WriteAt(b []byte, offset int64) (n int, err error) {
}

func deleteExpiredBuckets(prefix string) error {
Comment thread
BrennaEpp marked this conversation as resolved.
Resolved
if testing.Short() {
return nil
}

ctx := context.Background()
client, err := storage.NewClient(ctx)
if err != nil {
Expand Down Expand Up @@ -713,6 +717,9 @@ type downloadTestBucket struct {
// objects in it. All objects are of the same size but with different contents
// and can be mapped to their respective crc32c hash in contentHashes.
func (tb *downloadTestBucket) Create(prefix string) error {
if testing.Short() {
return nil
}
ctx := context.Background()

tb.bucket = prefix + uidSpace.New()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should talk about adding some more objects (at least more than the thread count) and of a wider variety of sizes. Can be in a follow up PR though.

Expand Down Expand Up @@ -752,6 +759,9 @@ func (tb *downloadTestBucket) Create(prefix string) error {

// Cleanup deletes the objects and bucket created in Create.
func (tb *downloadTestBucket) Cleanup() error {
if testing.Short() {
return nil
}
ctx := context.Background()

client, err := storage.NewClient(ctx)
Expand Down
⌂ 换网址