Skip to content

spanner/spansql: support for Protobuf column-types #10944

Closed

Description

@dfinkel

Client

Spanner

Environment

any

Code

I'll open a PR shortly adding support to the spansql package for parsing/canonicalizing protobuf types, and adding support for CREATE/ALTER/DROP PROTO BUNDLE statements.

Activity

  1. dfinkel commented on Oct 2, 2024

    @dfinkel
    ContributorAuthor

    I've filed #10945 to cover this.

    (As usual) I'm open to revisions/feedback.
    I mostly tried to follow the local style, but probably deviated in a few places.

  2. dfinkel commented on Oct 31, 2024

    @dfinkel
    ContributorAuthor

    The review on #10945 seems to have gone silent after I fixed a bug from a bad rebase/merge conflict.
    Would it be possible for someone to make another pass over that PR?
    Thanks!

  3. added 2 commits that reference this issue on Nov 6, 2024
    91c6f0f
    f32d0d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the Spanner API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址