Skip to content

feat(storage): expose Object.finalize_time on ObjectMetadata - #16558

Merged
kalragauri merged 2 commits into
googleapis:mainfrom
kalragauri:feat/finalize-time
Oct 13, 2026
Merged

kalragauri merged 2 commits into
googleapis:mainfrom
kalragauri:feat/finalize-time

Conversation

@kalragauri

Copy link
Copy Markdown
Contributor

This PR exposes the output-only finalize_time field (timeFinalized in JSON) on google::cloud::storage::ObjectMetadata, so callers of the synchronous client can determine whether an appendable object has been finalized or is still open for writes.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Oct 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the finalize_time (represented as timeFinalized in JSON) field within ObjectMetadata. The changes implement parsing of this field from both gRPC proto messages and JSON, extend the ObjectMetadata class with corresponding accessor and mutator methods, and add comprehensive unit tests to verify the new functionality under various scenarios. No review comments were provided, and the implementation fully conforms to the repository's style guidelines.

@kalragauri
kalragauri marked this pull request as ready for review October 12, 2026 08:11
@kalragauri
kalragauri requested review from a team as code owners October 12, 2026 08:11
@kalragauri
kalragauri requested a review from v-pratap October 12, 2026 08:11
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (b304472) to head (158559b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16558      +/-   ##
==========================================
- Coverage   92.38%   92.38%   -0.01%     
==========================================
  Files        2265     2265              
  Lines      219046   219107      +61     
==========================================
+ Hits       202367   202421      +54     
- Misses      16679    16686       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalragauri
kalragauri merged commit 68190fe into googleapis:main Oct 13, 2026
71 checks passed

This branch was previously deployed

1 inactive deployment
false — 158559b4 Deployed Oct 13, 2026 by kalragauri via Save PR ref #12402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址