Repository navigation
feat(storage): expose Object.finalize_time on ObjectMetadata - #16558
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for the finalize_time (represented as timeFinalized in JSON) field within ObjectMetadata. The changes implement parsing of this field from both gRPC proto messages and JSON, extend the ObjectMetadata class with corresponding accessor and mutator methods, and add comprehensive unit tests to verify the new functionality under various scenarios. No review comments were provided, and the implementation fully conforms to the repository's style guidelines.
kalragauri
force-pushed
the
feat/finalize-time
branch
from
October 12, 2026 08:10
547781a to
bc84a5f
Compare
kalragauri
marked this pull request as ready for review
October 12, 2026 08:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16558 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 2265 2265
Lines 219046 219107 +61
==========================================
+ Hits 202367 202421 +54
- Misses 16679 16686 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
v-pratap
approved these changes
Oct 13, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the output-only
finalize_timefield (timeFinalizedin JSON) ongoogle::cloud::storage::ObjectMetadata, so callers of the synchronous client can determine whether an appendable object has been finalized or is still open for writes.