Repository navigation
fix(storage): add unit tests for ReadRange bounded and unbounded completions - #16419
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates ReadRange::OnRead to automatically mark range_end as true when the remaining requested length of a bounded read reaches zero. This allows the range to complete immediately without waiting for an additional empty end-of-range message from the server. Corresponding unit tests have been added to verify this behavior for single-chunk bounded reads, multi-chunk bounded reads, and unbounded reads. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16419 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 2246 2246
Lines 212663 212734 +71
=======================================
+ Hits 196247 196322 +75
+ Misses 16416 16412 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rajeevpodar
requested changes
Sep 9, 2026
rajeevpodar
approved these changes
Sep 9, 2026
kalragauri
enabled auto-merge (squash)
September 9, 2026 11:37
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
ReadRangeto verify range completion semantics under various server response patterns:ReadRange(offset, length)wherelength > 0) auto-completes immediately when all requested bytes arrive, even if the server's response setsrange_end: false.ReadRange(offset, std::nullopt)) remains open across incoming chunks until the server explicitly signalsrange_end: true.