Skip to content

Providers don't do circular dependency detection #626

Closed

Description

@gissuebot

From sberlin on April 30, 2011 11:33:34

Providers can fail with StackOverflowErrors if the circular dependencies are purely with providers.  The current "re-entrant provider" failure only works if one of the dependencies didn't come from a Provider.

Providers should have full circular dependency detection, similar to how constructor bindings do it.

Original issue: http://code.google.com/p/google-guice/issues/detail?id=626

Activity

  1. gissuebot commented on Jul 7, 2014

    @gissuebot
    Author

    From sberlin on April 30, 2011 08:38:45

    fixed in r=1543

    Status: Fixed

  2. gissuebot commented on Jul 7, 2014

    @gissuebot
    Author

    From sberlin on April 30, 2011 08:39:07

    ( r1543 , that is)

  3. gissuebot commented on Jul 7, 2014

    @gissuebot
    Author

    From mcculls on May 04, 2011 11:03:02

    Testcase patch that shows interesting conflict wrt. circular provider proxies and injection listeners

    Attachment: gist
       CIRCULAR_DEPENDENCY_WITH_INJECTION_LISTENER_TEST.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址