Skip to content

Expose and/or matchers #1177

Closed
Closed

Description

@kashike

The and and or matcher implementations are restricted to use by AbstractMatcher, unlike the not (and other matchers in this class) matcher - would it be possible to expose these as Matchers.and(a, b) and Matchers.or(a, b)? This would allow use of these matchers without extending AbstractMatcher for the default implementation, or creating your own matchers.

Activity

  1. cterse commented on May 24, 2021

    @cterse

    Its been quite long since this issue was opened. Can I look into this?

  2. kashike commented on May 25, 2021

    @kashike
    ContributorAuthor
  3. kashike commented on Apr 29, 2023

    @kashike
    ContributorAuthor

    The and and or methods in Matcher could be default implemented now that Guice requires Java 8 - is this something that might be considered now, or is this a dead idea?

  4. sameb commented on Apr 29, 2023

    @sameb
    Member

    Yeah, that sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址