Repository navigation
Prevent ThreadPrefetchDatasetIterator.close() deadlock when parent iterator is blocked - #1461
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1018969110
branch
3 times, most recently
from
November 11, 2026 10:18
295bf69 to
4af46d8
Compare
…iterator is blocked `ThreadPrefetchDatasetIterator.close()` previously joined the background prefetch thread before closing its parent iterator. When the prefetch thread was blocked inside `parent.__next__()` waiting on an upstream resource that only unblocks upon `parent.close()`, `close()` deadlocked indefinitely. Make `close()` idempotent, signal both `_closed_event` and `_prefetch_should_stop`, clear buffered items, and close the parent iterator before joining the prefetch worker, check `closed` in `_put_iterator_elements_in_buffer` so an unblocked producer exits cleanly without dropping autotuned prefetch elements on buffer resize, and enqueue a closed sentinel after shutdown so any outer consumer blocked in `_buffer.get()` (such as nested `ThreadPrefetch` pipelines) unblocks cleanly. Fixes #1372. PiperOrigin-RevId: 1018969110
copybara-service
Bot
force-pushed
the
test_1018969110
branch
from
November 11, 2026 10:48
4af46d8 to
6140b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent
ThreadPrefetchDatasetIterator.close()deadlock when parent iterator is blockedThreadPrefetchDatasetIterator.close()previously joined the background prefetch thread before closing its parent iterator. When the prefetch thread was blocked insideparent.__next__()waiting on an upstream resource that only unblocks uponparent.close(),close()deadlocked indefinitely.Make
close()idempotent, signal both_closed_eventand_prefetch_should_stop, clear buffered items, and close the parent iterator before joining the prefetch worker, checkclosedin_put_iterator_elements_in_bufferso an unblocked producer exits cleanly without dropping autotuned prefetch elements on buffer resize, and enqueue a closed sentinel after shutdown so any outer consumer blocked in_buffer.get()(such as nestedThreadPrefetchpipelines) unblocks cleanly.Fixes #1372.