Repository navigation
Fix memory leak when fetching update history - #129
Merged
joshuasahayaarul merged 2 commits intoOct 30, 2023
Merged
Conversation
joshuasahayaarul
suggested changes
Oct 30, 2023
joshuasahayaarul
left a comment
joshuasahayaarul
left a comment
Contributor
There was a problem hiding this comment.
Hey, thank you for the PR. Sorry for the late review. Looks good, just one request.
joshuasahayaarul
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some missing .Clear() caused a memory leak when fetching the update history on Windows.
During the conversion of the properties. For example
toCategories(...was properly calling .Clear() but not some of the other conversions.