You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
database/sql: ability to get drivername from instance #12600
Reacted by Muhammad Shulhan, Aleksei Zhukov, Piotr Kochan, Oleg Shparber, Andrey Nering, bokwoon95, Gavin McTaggart, Yami Odymel, Qian Chen, Jonathan Hall and 5 more
I don't know what an sqlx is. When you open a *DB with https://golang.org/pkg/database/sql/#Open , can't you just remember the mapping between (driverName, dataSourceName) and the *DB yourself?
Reacted by Richard Patel
Reacted by Aleksei Zhukov, Yehuda Makarov, Qian Chen, CC11001100, Sal Rahman, Dominik Chrástecký and Andrew Depke
changed the title [-]database/sql : Ability to get drivername from instance[/-][+]database/sql: Ability to get drivername from instance[/+]on Oct 10, 2015
In this case, I am trying to avoid having to store another variable with the driver name and having to pass it around. Expect it could be added to the Db instance itself for convenienace instead.
Well thats one way to skin a cat, what I am having to do as a workaroundzzz,
is pass a struct{driver+creds+ nick+stuff} around....
and it seems daft to me that there is not a "field" for the want of the word that simply contains the driver_name and some meta data..
Example case.. Here u are with a new db connection... and a new project..
So before i start to even load that, I need to run around all the db admins asking ? which engine is this code using ?
so its daft.. in my case btw i run www sites + scripts and interfacing db's of all types.. so this is a "bane of contention" as I now need to move around all driver info et all, instead of a DB "object" that COULD do that for me.. Its a simple solution and i dont unserstand quite why it aint there.. to be honest..
type Driver interface {
// Open returns a new connection to the database.
// The name is a string in a driver-specific format.
//
// Open may return a cached connection (one previously
// closed), but doing so is unnecessary; the sql package
// maintains a pool of idle connections for efficient re-use.
//
// The returned connection is only used by one goroutine at a
// time.
Open(name string) (Conn, error)
Name << Sriver caches name for help down line later
}
Anyway. .sorry for rant..
package sqlexp
type Flavor int // Flavor of SQL text.
const (
Unknown Flavor = iota
Postgres
TSQL
MySQL
SQLite
)
// DriverFlavor returns the SQL variant used.
//
// Obtain the driver value with the sql.DB.Driver method.
func DriverFlavor(d driver.Driver) Flavor {
}
Then you just have to pass around the *sql.DB, right?
I have a similar need to know what is the SQL dialect of a database (MySQL, Oracle, etc.). For now, I manually maintain a list of Go driver package names and their dialects (eg. github.com/go-sql-driver/mysql => MySQL). So I get the package name using reflect on the driver instance. Ideally, I'd love a driver to provide the dialect its database has.
a given library would have to import many SQL drivers to be able to match them, even if the user will only use one of them
@andreynering It's hard to understand the use-case for this. If your code tries to match a specific driver, with a code path that is only taken when that driver is active supported anyways, what's the issue with importing its package? Modularization for shared libraries can be achieved via side-effect imports. Another cheap and easy option is checking matching the driver type via reflection: reflect.TypeOf(driver).String().
@terorie In short, it'll be imported and bloat the binary size without being used.
And an important detail: some SQL drivers require a C compiler to be available if imported, notably SQLite. That's annoying if the user is not using that driver at all.
I've shortly dealt with some Oracle drivers in the past, and they require even more complicated setups, just to compile the binary, even if you don't use it.
In short, it'll be imported and bloat the binary size without being used.
@andreynering I understand the concern about the import graph but there are other ways to solve this. To elaborate on my previous comment here are some options:
Inverse dependencies: Instead of having the generic component switch and invoke driver-specific code, offer driver wrappers to be imported via side-effect or similar (e.g. https://github.com/go-gorm/gorm)
Using a type switch through reflection rather than the regular .(type) switch.
changed the title [-]database/sql: Ability to get drivername from instance[/-][+]database/sql: ability to get drivername from instance[/+]on May 2, 2025
Activity
bradfitz commentedon Oct 10, 2015
I don't know what an
sqlxis. When you open a*DBwith https://golang.org/pkg/database/sql/#Open , can't you just remember the mapping between (driverName, dataSourceName) and the *DB yourself?[-]database/sql : Ability to get drivername from instance[/-][+]database/sql: Ability to get drivername from instance[/+]pedromorgan commentedon Oct 16, 2015
In this case, I am trying to avoid having to store another variable with the driver name and having to pass it around. Expect it could be added to the Db instance itself for convenienace instead.
bradfitz commentedon Oct 16, 2015
Maybe we could add it to
DBStats, so we don't add new methods toDBand users can just use the existingStatsmethod.msaron commentedon Feb 27, 2017
I need this functionality also. I am using some external libraries and they want the database connection and the driver name (as string).
kardianos commentedon Mar 30, 2017
One way you can do this today is to get the DB.Driver() and reflect on that type.
See https://github.com/golang-sql/sqlexp/blob/c2488a8be21d20d31abf0d05c2735efd2d09afe4/quoter.go#L46
for an example. It isn't foolproof as driver type names may change, but they usually don't.
pedromorgan commentedon Mar 30, 2017
Well thats one way to skin a cat, what I am having to do as a workaroundzzz,
is pass a struct{driver+creds+ nick+stuff} around....
and it seems daft to me that there is not a "field" for the want of the word that simply contains the driver_name and some meta data..
Example case.. Here u are with a new db connection... and a new project..
So before i start to even load that, I need to run around all the db admins asking ? which engine is this code using ?
so its daft.. in my case btw i run www sites + scripts and interfacing db's of all types.. so this is a "bane of contention" as I now need to move around all driver info et all, instead of a DB "object" that COULD do that for me.. Its a simple solution and i dont unserstand quite why it aint there.. to be honest..
https://golang.org/pkg/database/sql/driver/#Driver
pedromorgan commentedon Mar 30, 2017
@kardianos Make is "method" or something.. help me .. Im my case I am using multiple db's(as a new integrator)..
kardianos commentedon Mar 30, 2017
@pedromorgan You're fine. Are you aware of the DB.Driver method?
https://golang.org/pkg/database/sql/#DB.Driver
Let me think on this though. I created a playground for possible extensions:
https://godoc.org/github.com/golang-sql/sqlexp
as you saw before.
In the meantime I could create something like:
Then you just have to pass around the *sql.DB, right?
pedromorgan commentedon Mar 31, 2017
No.. I don't want contstants.. I want to know which driver am using.. from string
If its mysql = No spatial//
The only things I want passed is the Name() of the interface..
Is it postgis ?? is it mysql ?? is it gitsql ?? I need to know that cos I cant even create a connection+addoen unless I know that... !!
Othewise Please implement asap the Reflact Inteterface() which @bradfitz is probally correct in the stats module..
pedromorgan commentedon Mar 31, 2017
Here is the problem..
https://godoc.org/github.com/freeflightsim/fg-navdb/navdb
I want a local cache vs online one in same interface..
mattn commentedon Mar 31, 2017
The name should be considered for Flavor vs Dialect. 👍
5 remaining items
leoleoasd commentedon Jul 26, 2020
I also need this feature to know the driver name while doing database migrations cause different driver requires different SQL.
Julio-Guerra commentedon Sep 4, 2020
I have a similar need to know what is the SQL dialect of a database (MySQL, Oracle, etc.). For now, I manually maintain a list of Go driver package names and their dialects (eg. github.com/go-sql-driver/mysql => MySQL). So I get the package name using
reflecton the driver instance. Ideally, I'd love a driver to provide the dialect its database has.riptl commentedon Jan 30, 2021
I believe this issue has been solved.
It's trivial in recent Go versions.
andreynering commentedon Jan 30, 2021
@terorie The ability to get only the driver name would be better.
As you suggested, a given library would have to import many SQL drivers to be able to match them, even if the user will only use one of them.
If it returned a string, libraries would not need to import any driver at all, and the user will only import those he uses.
riptl commentedon Jan 30, 2021
@andreynering It's hard to understand the use-case for this. If your code tries to match a specific driver, with a code path that is only taken when that driver is
activesupported anyways, what's the issue with importing its package? Modularization for shared libraries can be achieved via side-effect imports. Another cheap and easy option is checking matching the driver type via reflection:reflect.TypeOf(driver).String().andreynering commentedon Jan 30, 2021
@terorie In short, it'll be imported and bloat the binary size without being used.
And an important detail: some SQL drivers require a C compiler to be available if imported, notably SQLite. That's annoying if the user is not using that driver at all.
I've shortly dealt with some Oracle drivers in the past, and they require even more complicated setups, just to compile the binary, even if you don't use it.
riptl commentedon Jan 30, 2021
@andreynering I understand the concern about the import graph but there are other ways to solve this. To elaborate on my previous comment here are some options:
.(type)switch.mohammadv184 commentedon Feb 14, 2023
there are any updates on the SQL get river name feature? this issue is still open.
elgs commentedon Apr 1, 2023
This is useful when your function receives *sql.DB or *sql.TX as a input parameter and you want to figure out what placeholders should be used.
elgs commentedon Apr 3, 2023
If this is done someday, please don't forget we want the db type from *sql.Tx as well. Go's sql sucks.
elgs commentedon Apr 3, 2023
Here is my hacks, how dirty!
[-]database/sql: Ability to get drivername from instance[/-][+]database/sql: ability to get drivername from instance[/+]