Repository navigation
Fix/coverage quirks - #85
Merged
Merged
Conversation
A field whose type is a model becomes a $ref, and a bare $ref carries no
siblings — so when the field's only decoration is prose, the legacy
default emits {$ref} and the description goes with it. That is deliberate
and unchanged here, but it was the one drop on that path that said
nothing: SkipAllOfCompounding reports every sibling it discards, while
the description-only default reported none. An author watching a
description vanish had nothing to tell them EmitRefSiblings would keep
it.
The drop now raises CodeDroppedRefSibling as a Hint, naming the field and
the option that preserves it. A Hint rather than a Warning: nothing is
wrong, the default simply cannot carry prose beside a $ref. The code's
documentation now describes both of its causes, told apart by severity.
No emitted spec changes — the goldens are untouched across the corpus,
which is the whole claim: only the diagnostic stream grew.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
walkPathItemProse guarded against a nil operation, but operationsByMethod yields only the methods a path item actually defines, so the branch could never be taken. It is gone, replaced by a comment saying why no guard is needed. walkSchemaProse's anyOf and oneOf arms, and the tuple form of items, cannot fire either — for a different reason: a Swagger 2.0 document has no such constructs. Those stay, because the walk has to remain total over the schema type and they become live the day the emitter targets OAS 3.x, but they now say so rather than reading as untested paths. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist