Repository navigation
chore(genspec-tui): refactor TUI - #82
Merged
Merged
Conversation
The root model held every concern at once, in 1775 lines. It is now 299, with the rest split by what owns it: cross-references, keys, source, chrome, scan flow, mouse. The help and scanner-options modals become packages, following the contract the panels already used. ScanState, RefCycle, SearchBox and SourceWatch each take a slice of the model's state. Cross-reference resolution becomes pure functions over the indexes. One test fixture replaces eighteen, and nineteen test files become nine. Behaviour is unchanged apart from ctrl+q, which now quits from the options popup and the search input as the keymap always claimed. The built binary committed by accident is gone from the tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root model held every concern at once, in 1775 lines. It is now 299, with the rest split by what owns it: cross-references, keys, source, chrome, scan flow, mouse.
The help and scanner-options modals become packages, following the contract the panels already used. ScanState, RefCycle, SearchBox and SourceWatch each take a slice of the model's state. Cross-reference resolution becomes pure functions over the indexes. One test fixture replaces eighteen, and nineteen test files become nine.
Behaviour is unchanged apart from ctrl+q, which now quits from the options popup and the search input as the keymap always claimed. The built binary committed by accident is gone from the tree.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist