Skip to content

[WebGPU] Fix indexing bug in softmax kernel - #32691

Open
nikhilJain17 wants to merge 26 commits into
ggml-org:masterfrom
nikhilJain17:nikhilJain17/webgpu-dispatch-2d
Open

nikhilJain17 wants to merge 26 commits into
ggml-org:masterfrom
nikhilJain17:nikhilJain17/webgpu-dispatch-2d

Conversation

@nikhilJain17

Copy link
Copy Markdown
Contributor

Overview

The softmax kernel finds softmax for each tensor's row. However, it does not always check if the thread's row is within the output range. This PR adds dst_rows as a parameter and checks that the row is in bounds before calculating softmax.

Additional information

Requirements

@nikhilJain17
nikhilJain17 marked this pull request as ready for review November 20, 2026 19:39
@nikhilJain17
nikhilJain17 requested review from a team and ggerganov as code owners November 20, 2026 19:39
@github-actions github-actions Bot added the testing Everything test related label Nov 20, 2026
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning WebGPU labels Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning testing Everything test related WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址