Repository navigation
Let 'config -w' create the config file it is pointed at - #417
Merged
Merged
Conversation
A config file named with --config had to exist before any command ran, including the one whose job is to write it. 'desync --config new.json config -w', the example in the command's own help and in the docs, failed with "no such file or directory" and wrote nothing. Record the missing file during initialization instead of exiting there, and report it before running any command other than 'config'. A config file that exists but can't be read or parsed remains fatal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A config file named with
--confighad to exist before any command ran, including the one whose job is to write it.desync --config new.json config -w, the example in the command's own help and indocs/configuration.md, failed withno such file or directoryand wrote nothing.The missing file is now recorded during initialization rather than being fatal there, and reported before running any command other than
config. A config file that exists but cannot be read or parsed remains fatal, and a missing config in the default location is still ignored.